Conversation
Malionaro
marked this pull request as draft
September 17, 2026 20:26
Owner
|
Could you please retarget this PR to dev? |
Malionaro
force-pushed
the
feat/fire-ignite-sync
branch
from
September 18, 2026 15:51
519a45a to
889bb58
Compare
Author
|
Done — retargeted to dev and rebased onto it. Since dev took Ids 31/32 + protocol v68 (brush batching), fire moved to Id 33 / v69. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicates building/tree fire starts: one FireIgniteCommand (new Id 33, protocol v68 -> v69) per ignition carrying prefab + position + intensity. Both sides capture and realize, converging on the union of fires. Burn, spread, rescue and extinguish stay local per machine (same start-only shape as disasters); damage converges via growable condition sync.
Realize adds OnFire to the prefab+position-matched target (2 m) the way the native ignite pipeline would — a replica never re-enters capture, so no echo guard is needed. Bounded: 4 realizes/frame, 10 s retry window, vehicle/untargeted ignites skipped with throttled logging. Exists-guards on all match-scan reads.
Note: upstream dev took Ids 31/32 (brush batching) and v68 after this branch was first written, so fire moved to Id 33 / v69 on top of dev.
Based on upstream dev 69cdebc. Developed in Malionaro#4. Needs a real multiplayer test session before merge.