Repository navigation
[Fix] Custom integration tools stay unavailable after a failed load - #3441
Merged
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 9, 2026 05:27
This was referenced Oct 9, 2026
daniel-lxs
approved these changes
Oct 9, 2026
daniel-lxs
left a comment
Member
There was a problem hiding this comment.
Verified catalog failure, repeated retry, pending state, recovery and normal policy updates in the running app with a controlled MCP provider. Focused client tests, web checks and current CI pass at this head.
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No linked issue; internal Roomote product work.
Why this PR exists
A failed custom MCP tool-catalog request leaves the open dialog with only Close, even after the server recovers. Add an in-place recovery action so users can continue managing the integration without closing and reopening the dialog.
What changed
Policy writes, personal/deployment scope, permissions and MCP protocol behavior retain their existing paths. The added state holds only the selected server ID and error text while its retry runs.
How it was tested
35201fbfusing the authenticated Integrations page, real local Postgres and server-side catalog fetch against a controlled MCP HTTP provider returning 503. Removing the failure did not give the open baseline dialog a recovery action.The provider is a disposable local deterministic MCP fixture with controlled 503/delay. The authenticated web UI, tRPC request, database lookup and server HTTP fetch are real; this is controlled-provider proof, not production or live-provider parity. Screenshots cover desktop-light (1440×900) and mobile-dark (390×844) error/pending/recovered layouts. Repeated failures, cache recovery and identity isolation are supported by behavioral tests rather than screenshots.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — the repository's normalpnpm lint:fast,pnpm check-types:fastandpnpm knipgates passed insteadpnpm changeset— release notes are derived from merged PRsRelated PRs
Screenshots
Controlled local MCP provider; these images prove the pictured dialog layouts and states, not live-provider correctness.
Desktop light: error, pending Retry, recovered catalog
Mobile dark: error, pending Retry, recovered catalog