Repository navigation
[Fix] Transcript scroll controls are unnamed for assistive users - #3443
roomote-roomote[bot] wants to merge 1 commit into
Conversation
|
No code issues found. See task Reviewed the accessible-name addition, native Button prop forwarding, and both session/task consumers. The default label reaches the button while preserving consumer overrides and scroll behavior. CI lint, type checking, and Knip passed; tests, app build, and JavaScript/TypeScript CodeQL were still running when checked. The browser-proof gap documented in the PR remains unverified by this code review. Reviewed 0ccb0be |
|
Draft-state correction at 2026-10-09 05:46 UTC: an authoritative read showed this PR had become non-draft at unchanged head |
Keep this PR draft. Visual proof is blocked by the capture step's shared five-minute timeout. A completed accepted proof handoff is missing; do not auto-promote this PR on clean automated review alone.
Related issue
No linked issue; internal Roomote accessibility work.
Why this PR exists
The existing arrow button for returning to the latest transcript message has no accessible name on either session or task pages. Assistive users encounter an unnamed action.
What changed
Give the shared button the default accessible name “Scroll to latest message”. Preserve the existing icon, appearance, scroll handler and consumer prop overrides. One attribute; no new state or dependency.
How it was tested
button-namefinding on this control.Remaining gap: the bounded visual-proof step timed out before independent proof review completed. Its partial images are not accepted proof and are not embedded. No further capture or proof recovery is currently authorized. This draft preserves the implementation; it is not ready for review under the requested proof standard.
Continuation, if a later instruction authorizes it: check out the exact pushed head, use disposable local transcript records with a unique event prefix to establish overflow, confirm the accessible name on session/task pages, exercise desktop keyboard/mobile pointer navigation, finish the accepted bounded proof handoff, reconcile exact-head checks/review and then reconsider readiness. No external messages or live inference calls are needed for the transcript records. Prior disposable records were deleted.
This does not claim whole-page accessibility or assistive-device parity. Adjacent pre-existing placeholder contrast, scroll-region and avatar ARIA findings are outside this single-control fix.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — normal fast lint/types/knip pre-push gates passed insteadpnpm changeset— not run for this one-line fixRelated PRs