[E2E Testing] Fix update e2e bottleneck - #3275
Conversation
|
Current Coverage: 99% Mypy errors on fix-update-e2e-bottleneck branch: 1164 |
|
🚨 Please update the changelog. This PR cannot be merged until |
|
Current Coverage: 99% Mypy errors on fix-update-e2e-bottleneck branch: 1164 |
matthew7838
left a comment
There was a problem hiding this comment.
LGTM, tested and worked as expected. I agree with the trade-off. The removed warning/log/diff files weren't very useful for the e2e update task anyway. Thanks for looking into this.
|
Current Coverage: 99% Mypy errors on fix-update-e2e-bottleneck branch: 1164 |
Context
Issue(s) closed by this pull request: closes #3224
What
Removes the
deepdiffcomparison of results from e2e test simulation runs from old expected results in the step prior to overwriting those results as the new expected e2e results.Why
There has been a bottleneck/outright stall out on certain machines (windows/linux primarily) in updating the e2e expected results. Initial indications were that this was occurring at the deepdiff comparison stage. Upon further investigation and reflection, this comparison is not a value add for the process of updating the expected results so it's been removed here to hopefully speed up the process.
How
In the update expected results code, there was a
deepdiffcomparison of the results from the run that just completed. This step has been removed here.Test plan
Input Changes
Output Changes
Filter