Repository navigation
TEST-001A3: make validation-error recapture test portable - #188
Merged
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Makes the existing untrusted-error recapture test deterministic on macOS and Linux Node 20 without changing production code.
The test no longer relies on V8's platform-specific return value for writing the special lazy
Error.stackslot. It still attempts the hostile write, then provesparseBoundedArrayemits a distinct fresh error with the fixed safe reason/message, empty serialization, and no hostile canary.Closes #187.
Scope
functions/requestValidation.test.jsonlyVerification
5004389bcc729b03b3615917eadc5922c926c0cbgit diff --check: passedBoundaries
requestValidation.jsis unchanged.Officer impact: None — test portability only.
Officer documentation: None — no officer task or public behavior changes.
Deployment evidence: Source/test/merge evidence only. Website, Firebase, Stripe, provider settings, and production behavior are unchanged and unverified by this PR.