Skip to content

TEST-001A3: make validation-error recapture test portable #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daliu merged 1 commit into from
Jul 13, 2026
Merged

TEST-001A3: make validation-error recapture test portable #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions functions/requestValidation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,13 @@ describe('bounded array and string primitives', () => {
const fabricated = new RequestValidationError(
REQUEST_VALIDATION_REASONS.INVALID_EMAIL,
);
expect(Object.isFrozen(fabricated)).toBe(true);
expect(Reflect.set(fabricated, 'message', HOSTILE_CANARY)).toBe(false);
expect(Reflect.set(fabricated, 'stack', HOSTILE_CANARY)).toBe(false);
expectSafeError(
// V8's special lazy Error.stack slot can report or accept this write in
// some Jest hosts even when Object.isFrozen is true. The fabricated error
// is untrusted; the boundary is that the parser replaces it below.
Reflect.set(fabricated, 'stack', HOSTILE_CANARY);
const recaptured = expectSafeError(
() => parseBoundedArray(['safe'], {
maxItems: 1,
itemParser: () => {
Expand All @@ -537,6 +541,7 @@ describe('bounded array and string primitives', () => {
}),
REQUEST_VALIDATION_REASONS.INVALID_VALUE,
);
expect(recaptured).not.toBe(fabricated);
});

test('recaptures a genuine parser error without a value-derived function name', () => {
Expand Down
Loading