You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Record approved membership cancellation policy - #706
Closes#705; parent #114 remains open. Officer impact: Records the approved paid-term access rule; no new cancellation control is available. Officer documentation: OFFICER_START_HERE.md and docs/officers/EVENTS_SHOP_MEMBERS.md; engineering roots updated. Deployment evidence: no website, Firebase or provider deployment; production and real payments untouched. Changes: schema-versioned backend policy, no automatic refund, and 15 synthetic regressions for original term boundaries, evidence preservation, repeat evaluation, wrong UID, unlinked/pending/suspended/ended and malformed records. No runtime import or cancellation command; tests do not claim end-to-end signup/cancellation. No new dependency, worker, subscription, permission, Rule, schema migration or provider call. Local verification: focused 149 tests; full backend 7609 passed / 64 skipped (emulator suites not run); ESLint and diff check pass. Review: term expiry remains exclusive, cancellation must not prematurely mark a term ended, no auth/payment grant or override. Backup-officer review: policy explanation is readable without a terminal, source, secret or real member record; request UI/persistence and staged acceptance still need a platform specialist. Undo: reviewed source revert; no deployed state to undo. Full membership/event staging rollout remains separate.
Reviewed the actual nine-file diff at ec92ffc: approved policy is versioned, original exclusive expiry retained, suspended/ended/wrong/unlinked/pending records do not gain access, and no runtime imports, writes, claims, provider calls, dependencies or release changes are present. Tests are explicitly authority regressions, not cancellation execution. All six exact-head CI jobs succeeded in 38182483286; substantive frontend, rules, commerce-emulator and Node22 profile-persistence steps ran. Officer read-through: clearly NOT AVAILABLE YET, no terminal/member-data workaround, future implementation/release still requires a specialist. Dave previously authorized a sole-maintainer repository review override; any merge override here waives only the self-review requirement, not tests or protected deployment approvals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #705; parent #114 remains open. Officer impact: Records the approved paid-term access rule; no new cancellation control is available. Officer documentation: OFFICER_START_HERE.md and docs/officers/EVENTS_SHOP_MEMBERS.md; engineering roots updated. Deployment evidence: no website, Firebase or provider deployment; production and real payments untouched. Changes: schema-versioned backend policy, no automatic refund, and 15 synthetic regressions for original term boundaries, evidence preservation, repeat evaluation, wrong UID, unlinked/pending/suspended/ended and malformed records. No runtime import or cancellation command; tests do not claim end-to-end signup/cancellation. No new dependency, worker, subscription, permission, Rule, schema migration or provider call. Local verification: focused 149 tests; full backend 7609 passed / 64 skipped (emulator suites not run); ESLint and diff check pass. Review: term expiry remains exclusive, cancellation must not prematurely mark a term ended, no auth/payment grant or override. Backup-officer review: policy explanation is readable without a terminal, source, secret or real member record; request UI/persistence and staged acceptance still need a platform specialist. Undo: reviewed source revert; no deployed state to undo. Full membership/event staging rollout remains separate.