Skip to content

[ryoku] audio: merge the duplicate onSinkChanged handlers - #733

Merged
neur0map merged 1 commit into
Ryoku-dev:unstable-devfrom
CratusGod:fix/audio-duplicate-onsinkchanged
Nov 5, 2026
Merged

neur0map merged 1 commit into
Ryoku-dev:unstable-devfrom
CratusGod:fix/audio-duplicate-onsinkchanged

Conversation

@CratusGod

Copy link
Copy Markdown

What changed

1b2d040 (visualizer: follow default audio sink changes) added onSinkChanged: listSettle.restart() to services/Audio.qml. That file already had onSinkChanged: if (root.sinkIsBluez) root.refreshBtCard() further down. QML rejects a handler set twice, so on 1.8.8 the shell dies at launch:

ERROR: caused by file:///home/<user>/.config/quickshell/shell/services/Audio.qml[238:5]: Property value set multiple times
shell died at once

The bar, dock and everything else in the shell stay down. This merges both into one onSinkChanged handler that restarts the list settle and refreshes the bluez card.

Area

ryoku

How it was tested

On ryoku-desktop 1.8.8.r5818.g5dca77d (unstable, Hyprland), the shell crash-looped with the error above. After the same change was applied to the materialized Audio.qml and the shell reloaded, it starts, the bar is back, and the journal shows no more QML errors. qmllint does not flag the duplicate, so it would not have caught this.

Checklist

  • One logical change, with a clear [area] scope: summary commit subject.
  • Matching CHANGELOG.md updated in the area I touched.
  • The git hooks pass locally; I did not use --no-verify.
  • QML passes qmllint where applicable.
  • No duplicated config, no dead code, no commented-out code, no em-dash.
  • Docs updated if behavior or layout changed (no behavior change beyond the fix).

1b2d040 added a second onSinkChanged to services/Audio.qml beside the
existing bluez card refresh. QML rejects a handler set twice ("Property
value set multiple times"), so the shell died at launch on 1.8.8. One
handler now restarts the list settle and refreshes the bluez card.

Note: Fixed: The shell starts again on 1.8.8 instead of dying at launch on Audio.qml
@neur0map
neur0map merged commit 107ff71 into Ryoku-dev:unstable-dev Nov 5, 2026
3 checks passed
@neur0map

neur0map commented Nov 5, 2026

Copy link
Copy Markdown
Member

Thanks for catching this first, the same fix was already live on unstable so I merged yours on record and it goes out with the next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants