Repository navigation
[ryoku] audio: merge the duplicate onSinkChanged handlers - #733
Merged
neur0map merged 1 commit intoNov 5, 2026
Merged
Conversation
1b2d040 added a second onSinkChanged to services/Audio.qml beside the existing bluez card refresh. QML rejects a handler set twice ("Property value set multiple times"), so the shell died at launch on 1.8.8. One handler now restarts the list settle and refreshes the bluez card. Note: Fixed: The shell starts again on 1.8.8 instead of dying at launch on Audio.qml
Member
|
Thanks for catching this first, the same fix was already live on unstable so I merged yours on record and it goes out with the next update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1b2d040 (visualizer: follow default audio sink changes) added
onSinkChanged: listSettle.restart()toservices/Audio.qml. That file already hadonSinkChanged: if (root.sinkIsBluez) root.refreshBtCard()further down. QML rejects a handler set twice, so on 1.8.8 the shell dies at launch:The bar, dock and everything else in the shell stay down. This merges both into one
onSinkChangedhandler that restarts the list settle and refreshes the bluez card.Area
ryoku
How it was tested
On ryoku-desktop 1.8.8.r5818.g5dca77d (unstable, Hyprland), the shell crash-looped with the error above. After the same change was applied to the materialized
Audio.qmland the shell reloaded, it starts, the bar is back, and the journal shows no more QML errors.qmllintdoes not flag the duplicate, so it would not have caught this.Checklist
[area] scope: summarycommit subject.CHANGELOG.mdupdated in the area I touched.--no-verify.qmllintwhere applicable.