Skip to content

[ryoku] audio: merge the duplicate onSinkChanged handlers #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neur0map merged 1 commit into from
Nov 5, 2026
Merged

[ryoku] audio: merge the duplicate onSinkChanged handlers #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ryoku/shell/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Changelog: ryoku/shell/

## Unreleased
- **The shell starts again after the visualizer sink fix.** `services/Audio.qml`
declared `onSinkChanged` twice, which QML rejects as "Property value set
multiple times", so the shell died at launch. The two handlers are now one.
- **Visualizers follow newly connected audio outputs.** Bar and desktop
visualizers retarget when the default output changes without a shell reload.
- **A crashed lock screen comes back after display-link churn.** Once qylock has
Expand Down
7 changes: 5 additions & 2 deletions ryoku/shell/quickshell/shell/services/Audio.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,11 @@ Singleton {
onLiveCaptureStreamsChanged: listSettle.restart()
onLiveLinksChanged: listSettle.restart()

onSinkChanged: listSettle.restart()
onSinkChanged: {
listSettle.restart();
if (root.sinkIsBluez)
root.refreshBtCard();
}
Component.onCompleted: root.syncAudioLists()

function setOutput(n) { if (n) Pipewire.preferredDefaultAudioSink = n; }
Expand Down Expand Up @@ -235,7 +239,6 @@ Singleton {

readonly property bool sinkIsBluez: root.isBluez(root.sink)
onSinkIsBluezChanged: root.refreshBtCard()
onSinkChanged: if (root.sinkIsBluez) root.refreshBtCard()

// MAC from a bluez node name (bluez_output.<MAC>.<profile>), colon-formatted.
function btMac(n) {
Expand Down
Loading