AUTH-9 - Implemented UserProject server actions by leec18 · Pull Request #5 · SGAOperations/auth

leec18 · 2026-04-07T00:57:14Z

Created lib/userProject.ts for managing the UserProject join table which contains:

createUserProject: prevents duplicate assignments by checking for an existing record before inserting
getUserProject
getUserProjects: optional filtering by userId or projectId
deleteUserProject

SGAOperations · 2026-04-07T17:27:16Z

+}
+
+export function EmailForm({ onNext }: Props) {
+  const [email, setEmail] = useState("");


lets install react hook form and zod (or other packages if you have better ones) for this to avoid having useStates cause that gets out of hand very quickly

we can integrate with shadcn here too. They seem to support both react hook form and tanstack form so take your pick! https://ui.shadcn.com/docs/forms

SGAOperations · 2026-04-07T17:27:32Z

+      </button>
+    </form>
+  );
+}


new line end of file please

SGAOperations · 2026-04-07T17:28:18Z

+        onChange={(e) => setEmail(e.target.value)}
+        required
+      />
+      <button


lets install the shadcn button from here

SGAOperations · 2026-04-07T17:30:28Z

  color: var(--foreground);
  font-family: Arial, Helvetica, sans-serif;
 }
+


Could you set up a tailwind config and colors file? Guide: https://tailwindcss.com/docs/installation/framework-guides/nextjs

All of our colors for the application should be defined in this file (e.g. primary, secondary, accent, etc) and then referenced by those names throughout all files

SGAOperations · 2026-04-07T17:31:17Z

+      </div>
+    </main>
+  );
+}


Please add newlines at the ends of all files

SGAOperations · 2026-04-07T17:35:21Z

+
+async function createUserProject(userId: string, projectId: string) {
+    const existing = await prisma.userProject.findUnique({
+        where: { userId_projectId: { userId, projectId } }


lets move this inline

SGAOperations · 2026-04-07T17:35:51Z

+}
+
+async function getUserProject(userId: string, projectId: string) {
+    return await prisma.userProject.findUnique({


also move inline, anything this short can be inline

SGAOperations · 2026-04-07T17:36:44Z

+    });
+}
+
+async function getUserProjects(filters?: { userId?: string, projectId?: string }) {


for simplicity, lets destructure the args in the function definition so go { userId?, projectId? } : { userId: ..., projectId: string } or however it goes

SGAOperations · 2026-04-07T17:37:01Z

+}
+
+async function deleteUserProject(userId: string, projectId: string) {
+    return await prisma.userProject.delete({


do we have soft deletes for this or not on this one?

SGAOperations · 2026-04-07T17:37:12Z

+    });
+}
+
+async function deleteUserProject(userId: string, projectId: string) {


this might be better off being named removeUserFromProject

pataniaeli

Review written by a Claude agent.

Quick note before the rest: none of the four functions in this file are exported yet, so as merged today this genuinely is inert — nothing can call it. That's consistent with a "land the data layer now, wire up an authenticated action layer in a follow-up" plan, which seems like a reasonable way to sequence this. The comments below are mostly about what needs to be true by the time export gets added (which the PR title suggests is coming soon), plus one thing that blocks the build regardless.

Must-fix regardless of sequencing:

This doesn't currently build — tsc fails with three TS2353 errors from deletedAt being nested inside the compound-key where clause (see inline comment on createUserProject; same pattern repeats in getUserProject and removeUserFromProject). Worth fixing before merge independent of anything else here.
The upsert in createUserProject silently un-revokes a soft-deleted membership with no audit trail (see inline comment).
No input validation — zod is already a dependency elsewhere in the repo.
prettier --check currently fails on this file (brace spacing, trailing whitespace) — this repo's CLAUDE.md treats format:check as a merge gate.

Pending authz ticket / for whenever export gets added (see note above):

createUserProject/removeUserFromProject will need a caller-identity + authority check the moment they're exported, since this table is the authorization-scoping mechanism for the whole multi-tenant system (see inline comment).
getUserProjects({}) currently has no scoping and would return every membership across every project once reachable.

Worth its own ticket, not introduced by this PR: same RLS gap flagged on the other open PRs — UserProject sits in the same unprotected schema, which matters even more here since this table is the actual access-control list.

(Edit: corrected the inline comment anchors below that were off in my first pass — same content, right lines now.)

pataniaeli · 2026-08-16T03:06:04Z

+import { prisma } from "@/lib/prisma";
+
+async function createUserProject(userId: string, projectId: string) {
+    const existing = await prisma.userProject.findUnique({ where: { userId_projectId: { userId, projectId, deletedAt: null } }});


deletedAt: null is nested inside the compound-key object here, but Prisma's generated UserProjectUserIdProjectIdCompoundUniqueInput type only has userId/projectId — running tsc --noEmit against this branch fails here (and at the matching spots in getUserProject/removeUserFromProject) with TS2353: Object literal may only specify known properties. This one's independent of anything else in the review — npm run build won't pass as-is. The fix is to move deletedAt: null up a level, alongside the compound key (where: { userId_projectId: { userId, projectId }, deletedAt: null }), not to just delete it — deleting it would make a soft-deleted membership permanently block re-adding that user (see the upsert note below).

pataniaeli · 2026-08-16T03:06:04Z

+    if (existing) {
+        throw new Error("User project already exists");
+    }
+    return await prisma.userProject.upsert({


Once the type error above is fixed, this upsert will silently resurrect a previously soft-deleted membership (update: { deletedAt: null }) with no change to createdAt and no audit trail that access was ever removed and re-granted. Worth setting a fresh timestamp (or a dedicated restoredAt field) on the update branch so a re-grant is visible later, independent of whatever authorization ends up wrapping this function.

pataniaeli · 2026-08-16T03:06:04Z

+"use server";
+import { prisma } from "@/lib/prisma";
+
+async function createUserProject(userId: string, projectId: string) {


Noticed none of the four functions in this file are actually exported yet, so as merged this is dead code and not reachable — which reads like this might genuinely be the "data layer first, action layer later" pattern. If that's the plan, just want to flag it explicitly: whenever export gets added here (which the PR title implies is coming), it'll need a caller-identity + authority check attached at the same time, since UserProject is the authorization-scoping table for the whole system — an unauthenticated grant/revoke here is more consequential than on the other open PRs. Also worth scoping getUserProjects (line 22) to the caller once it's exposed — an empty {} filter currently returns every membership across all projects.

SGAOperations assigned leec18 Apr 7, 2026

SGAOperations self-requested a review April 7, 2026 19:07

SGAOperations requested changes Apr 7, 2026

View reviewed changes

AUTH-9 UserProject server actions

734e6be

leec18 force-pushed the auth-9 branch from 1ac8756 to 734e6be Compare April 7, 2026 21:12

AUTH-9 Implemented soft delete and renamed deleteUserProject()

4d41c92

pataniaeli requested changes Aug 16, 2026

View reviewed changes

pataniaeli reviewed Aug 16, 2026

View reviewed changes

+                    </div>
+                  </main>
+                );
+              }

                
                    No newline at end of file

Conversation

leec18 commented Apr 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pataniaeli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pataniaeli left a comment •

edited

Loading