Skip to content

AUTH-9 - Implemented UserProject server actions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leec18 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

AUTH-9 - Implemented UserProject server actions #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
734e6be
AUTH-9 UserProject server actions
leec18 Apr 7, 2026
4d41c92
AUTH-9 Implemented soft delete and renamed deleteUserProject()
leec18 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/lib/userProject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
"use server";
import { prisma } from "@/lib/prisma";

async function createUserProject(userId: string, projectId: string) {

@pataniaeli pataniaeli Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed none of the four functions in this file are actually exported yet, so as merged this is dead code and not reachable — which reads like this might genuinely be the "data layer first, action layer later" pattern. If that's the plan, just want to flag it explicitly: whenever export gets added here (which the PR title implies is coming), it'll need a caller-identity + authority check attached at the same time, since UserProject is the authorization-scoping table for the whole system — an unauthenticated grant/revoke here is more consequential than on the other open PRs. Also worth scoping getUserProjects (line 22) to the caller once it's exposed — an empty {} filter currently returns every membership across all projects.

const existing = await prisma.userProject.findUnique({ where: { userId_projectId: { userId, projectId, deletedAt: null } }});

@pataniaeli pataniaeli Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deletedAt: null is nested inside the compound-key object here, but Prisma's generated UserProjectUserIdProjectIdCompoundUniqueInput type only has userId/projectId — running tsc --noEmit against this branch fails here (and at the matching spots in getUserProject/removeUserFromProject) with TS2353: Object literal may only specify known properties. This one's independent of anything else in the review — npm run build won't pass as-is. The fix is to move deletedAt: null up a level, alongside the compound key (where: { userId_projectId: { userId, projectId }, deletedAt: null }), not to just delete it — deleting it would make a soft-deleted membership permanently block re-adding that user (see the upsert note below).

if (existing) {
throw new Error("User project already exists");
}
return await prisma.userProject.upsert({

@pataniaeli pataniaeli Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the type error above is fixed, this upsert will silently resurrect a previously soft-deleted membership (update: { deletedAt: null }) with no change to createdAt and no audit trail that access was ever removed and re-granted. Worth setting a fresh timestamp (or a dedicated restoredAt field) on the update branch so a re-grant is visible later, independent of whatever authorization ends up wrapping this function.

where: { userId_projectId: { userId, projectId } },
update: {deletedAt: null},
create: { userId, projectId } });
}

async function getUserProject(userId: string, projectId: string) {
return await prisma.userProject.findUnique({

@SGAOperations SGAOperations Apr 7, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also move inline, anything this short can be inline

where: { userId_projectId: { userId, projectId, deletedAt: null } } }
);
}


async function getUserProjects({userId, projectId}: { userId?: string, projectId?: string }) {
return await prisma.userProject.findMany({
where: { userId, projectId, deletedAt: null },
});
}

async function removeUserFromProject(userId: string, projectId: string) {
return await prisma.userProject.update({
where: { userId_projectId: { userId, projectId, deletedAt: null } },
data: { deletedAt: new Date() }
});
}