Repository navigation
fix: contracts single source of truth, route health smoke test, README setup, and price-tick motion - #996
Merged
IbrahimIjai merged 3 commits intoOct 19, 2026
Conversation
…, and price-tick motion
|
@Jaydbrown is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Jaydbrown Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request resolves issues #860, #861, #862, and #873 across config, testing, documentation, and UX motion:
Issue Contract IDs in apps/web/.env.testnet disagree with packages/contracts/contracts.json (14 of 18 differ) #860: Single source of truth for contract addresses (
contracts.json)packages/contracts/contracts.jsonto include all testnet contract IDs deployed on 2026-06-05 and structurednetworks.testnetandnetworks.mainnetmapping.contract-descriptions.jsondescriptions for all contract bindings.ContractAddresses,SupportedNetwork,CONTRACT_DEPLOYMENTS, andgetContractAddressesfrom@workspace/contracts.apps/web/src/app/config/contracts.tsto source directly from@workspace/contracts(getContractAddresses(ENV.NETWORK)).VITE_CONTRACT_*from required env vars inapps/web/src/app/config/env.ts,apps/web/.env.testnet,apps/web/.env.example, andapps/web/.env.mainnet.oracle.tsto importCONTRACTS.tokensinstead ofENV.CONTRACTS.TOKENS.apps/web/src/app/config/contracts.test.tsandpackages/contracts/src/deployments.test.ts.Issue Add a browser smoke test that fails on console errors and SSR fallbacks for every route #861: Route health smoke test (
e2e/route-health.spec.ts)e2e/route-health.spec.tscovering all routes (/,/trade,/pools,/earn,/referrals,/faucet,/gallery,/changelog,/design-system) at desktop (1440x900) and mobile (390x844) viewports.binance,stellar.org,gmxinfra.io,pyth.network).pageerrors, zero unhandled consoleerrors, zero SSR hydration mismatches, and zero same-origin 4xx/5xx responses.Issue README setup is incomplete: env step missing and
bun buildis the wrong command #862: README setup completion & command fixesbun buildtobun run buildinREADME.mdand the scripts table.localhost:3000.packages/contracts/contracts.jsonsingle source of truth for contract IDs and optional SubQuery indexer local setup.apps/web/.env.examplewith working testnet defaults and only developer-overridable settings.Missing env var: VITE_*.Issue [Motion] Price-tick flash in the order book and last price #873: Price-tick flash in the order book and last price
.so4-flash-up-overlay(green via--color-long) and.so4-flash-down-overlay(red via--color-short) topackages/ui/src/styles/globals.cssusing motion tokensvar(--duration-slow)(300ms) andvar(--ease-out).@media (prefers-reduced-motion: reduce)and:root[data-reduced-motion="true"]rules ensuring zero animation / instant 0 opacity fallback.DepthLadder.tsx:SpreadRowflashes green on tick up and red on tick down.apps/web/src/features/trade/components/orderbook/DepthLadder.test.tsx.Closes #860
Closes #861
Closes #862
Closes #873