Repository navigation
fix(evals): score only exact-run transcripts and preserve agent failures - #4247
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
845cbe7 to
c88db3a
Compare
Bind evidence to the invocation, session, project and corpus index. Preserve setup and agent exits and reject missing or invalid evidence. Include scorer, shell-runner and scorecard regression coverage. Run focused read-only harness checks on pull requests, including drafts. Fixes #4204
c88db3a to
b553ad0
Compare
|
Rewrote the complete PR history with the owner's authorization: 6 commits are now one, The new commit reuses the exact prior root tree Read back the PR commit list to verify it contains only the new, conventionally named commit. Existing focused evaluation evidence is still relevant to the identical files, but the current-head CI results must be checked separately before merge. |
Summary
Fixes #4204.
The hermetic scorer uses only the Claude session identified by the current invocation and validates recorded session/project identity. Missing, ambiguous, foreign, unreadable, or malformed evidence is an error—not a fallback to an older transcript. Codex uses its actual MCP
toolfield without double-counting started/completed events.The runner preserves setup, agent, and verification exits; skips downstream effects after prerequisite failures; refuses missing explicit projects; and emits structured error/status fields before returning a failing batch status.
Review follow-ups are included:
scenario_index, stable across repetitions. The scorecard pairs(scenario_index, rep)while validating the display ID/category against the indexed corpus entry. Duplicate labels no longer collide. Legacy unindexed results retain their unique-ID rules; mixed or invalid identity schemes are refused.scenario/prompt_invalidrow without running setup, the agent, or verification. They cannot disappear from a failing batch's report.Verified CI
Initial exact-run verification executed and passed
score_test,run_test, andscorecard_testthrough Bazel.Reporting follow-up verification applied the reviewed identity/prompt changes, executed the same three Bazel targets with the additional regressions, checked shell syntax and whitespace, and committed the tested source through a separate artifact-publishing job. No paid model evaluations ran.
The temporary owner-scoped repair/publishing steps have been removed. The retained
.github/workflows/hermetic-evals.ymlis a small read-only workflow running those three targets for harness changes, including drafts. Full ready-PR CI remains separate and must satisfy repository merge requirements.Regression coverage includes exact-session success; missing, foreign, ambiguous and malformed evidence; nonzero agent exits despite success-looking output; setup failures; real shell corpus orchestration; missing projects; duplicate display IDs; invalid prompts; scorecard identity tampering; and Codex event handling.
Related #4216 (grading quality), #4205 (memory-eval daemon lifecycle), and #4219 (product-wide outcomes) remain separate.