Repository navigation
Conversation
MarkdownString overrides _normalize_string to keep Unicode and case, and the override also dropped the URL derendering that the base class does first. The expected README of template 88 (tasks 562 to 566) writes its links with the site template (__REDDIT__/f/DIY/...), while a committed README holds the site's address (http://localhost:9999/f/DIY/...), so the content check could not match a real commit. Derender the same way the base class does.
The forum renders the title "GE Water Heater Pilot Light Won't Stay Lit" with a typographic apostrophe (U+2019), and an agent that copies the title from the page commits it so; the expected README of tasks 562, 563, 565 and 566 writes a straight one. MarkdownString keeps Unicode as is, so the content check fails on that one character. Fold the four typographic quotes and apostrophes to their ASCII forms, as NormalizedString already does through unidecode.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks 562-566 check the committed README with
MarkdownString, and on 1.2.3 a correct README cannot match:MarkdownString._normalize_stringskips the URL derendering that the base class does first. The expected links are__REDDIT__/f/DIY/...and a committed README's arehttp://localhost:9999/f/DIY/..., so they never compare equal.NormalizedStringalready folds this through unidecode, butMarkdownStringkeeps U+2019.One commit each: derender as the base class does, and fold U+2018, U+2019, U+201C and U+201D to ASCII. Five new tests in
test_markdown_string.py, built from READMEs my runs committed for 564 and 562, fail before and pass after.pytest -m "not docker"with CI's ignores: 5680 passed before, 5685 after, 6391 skipped. Ruff, ty and actionlint pass.566 still fails for a separate reason (its two checks want different repository paths); issue to follow.