Repository navigation
JVNAUTOSCI-2592: fix KR description output contract - #301
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a KR workflow seed output-contract mismatch that caused guarded KR materialisation to fail metadata validation during post-merge replay, and regenerates the dependent spreadsheet-programme seed bundle to reflect the corrected KR dependency.
Changes:
- Update the KR materialisation seed mapping so
kr_description_relation_idis sourced fromupsert_singleton_text_relation.kept_relation_id(instead of the nonexistentrelation_idoutput). - Bump the KR seed bundle version to v5 and regenerate the spreadsheet-programme representation workflow seed bundle to v18 with an updated processing-authority fingerprint and KR dependency digest.
- Add regression assertions validating both KR description output mappings (
kr_description_relation_id,kr_description_text_value_id) and update seed-version assertions in the spreadsheet-programme workflow tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/backend/test_spreadsheet_programme_workflow_vontology_service.py | Updates expectations for regenerated spreadsheet-programme seed bundle v18 and KR dependency v5. |
| tests/backend/test_kr_materialisation_workflow_vontology_service.py | Adds regression assertions ensuring KR description output mappings match the tool’s real output fields. |
| src/backend/workflows/repo_seed_bundles/spreadsheet_programme_representation_workflow_seed_bundle.json | Regenerated seed bundle v18 with updated processing-authority fingerprint and KR dependency identity. |
| src/backend/workflows/repo_seed_bundles/kr_materialisation_workflow_seed_bundle.json | Bumps KR seed to v5 and fixes the kr_description_relation_id tool output mapping to kept_relation_id. |
| scripts/generate_spreadsheet_programme_workflow_seed.py | Bumps generator-produced seed_version to 18 to match the regenerated bundle. |
| "schema_version": "repo_seed_workflow_bundle.v1", | ||
| "seed_version": "4", | ||
| "seed_version": "5", | ||
| "source_tag": "JVNAUTOSCI-2271", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live failure
The post-merge one-record replay reached the guarded KR child and stopped after its first reuse item. The singleton description mutation succeeded, but workflow metadata validation failed because the represented step mapped a nonexistent
relation_idoutput.Fix
upsert_singleton_text_relation.kept_relation_idtokr_description_relation_idsha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3Validation