Skip to content

JVNAUTOSCI-2592: fix KR description output contract - #301

Merged
witbrock merged 1 commit into
mainfrom
jvnautosci-2592-description-output-contract
Jul 24, 2026
Merged

witbrock merged 1 commit into
mainfrom
jvnautosci-2592-description-output-contract

Conversation

@witbrock

Copy link
Copy Markdown
Member

Live failure

The post-merge one-record replay reached the guarded KR child and stopped after its first reuse item. The singleton description mutation succeeded, but workflow metadata validation failed because the represented step mapped a nonexistent relation_id output.

Fix

  • map upsert_singleton_text_relation.kept_relation_id to kr_description_relation_id
  • bump KR seed v4 to v5
  • regenerate the dependent spreadsheet bundle as seed v18 with fingerprint sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3
  • add a regression assertion for both description output mappings

Validation

  • 19 focused tests pass
  • KR bundle validation and seed-version checks pass
  • generator output, Ruff, formatting, and diff checks pass
  • live failure made zero creates and wrote no record marker; retry remains safe and idempotent

Copilot AI review requested due to automatic review settings July 24, 2026 05:04
@witbrock
witbrock marked this pull request as ready for review July 24, 2026 05:04
@witbrock
witbrock merged commit 947eb8d into main Jul 24, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a KR workflow seed output-contract mismatch that caused guarded KR materialisation to fail metadata validation during post-merge replay, and regenerates the dependent spreadsheet-programme seed bundle to reflect the corrected KR dependency.

Changes:

  • Update the KR materialisation seed mapping so kr_description_relation_id is sourced from upsert_singleton_text_relation.kept_relation_id (instead of the nonexistent relation_id output).
  • Bump the KR seed bundle version to v5 and regenerate the spreadsheet-programme representation workflow seed bundle to v18 with an updated processing-authority fingerprint and KR dependency digest.
  • Add regression assertions validating both KR description output mappings (kr_description_relation_id, kr_description_text_value_id) and update seed-version assertions in the spreadsheet-programme workflow tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/backend/test_spreadsheet_programme_workflow_vontology_service.py Updates expectations for regenerated spreadsheet-programme seed bundle v18 and KR dependency v5.
tests/backend/test_kr_materialisation_workflow_vontology_service.py Adds regression assertions ensuring KR description output mappings match the tool’s real output fields.
src/backend/workflows/repo_seed_bundles/spreadsheet_programme_representation_workflow_seed_bundle.json Regenerated seed bundle v18 with updated processing-authority fingerprint and KR dependency identity.
src/backend/workflows/repo_seed_bundles/kr_materialisation_workflow_seed_bundle.json Bumps KR seed to v5 and fixes the kr_description_relation_id tool output mapping to kept_relation_id.
scripts/generate_spreadsheet_programme_workflow_seed.py Bumps generator-produced seed_version to 18 to match the regenerated bundle.

"schema_version": "repo_seed_workflow_bundle.v1",
"seed_version": "4",
"seed_version": "5",
"source_tag": "JVNAUTOSCI-2271",
@witbrock
witbrock deleted the jvnautosci-2592-description-output-contract branch July 28, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants