Skip to content

JVNAUTOSCI-2592: fix KR description output contract #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
witbrock merged 1 commit into from
Jul 24, 2026
Merged

JVNAUTOSCI-2592: fix KR description output contract #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/generate_spreadsheet_programme_workflow_seed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1594,7 +1594,7 @@ def build_bundle() -> dict[str, object]:
return {
"family_id": "spreadsheet_programme_representation_workflow_seed_bundle",
"schema_version": "repo_seed_workflow_bundle.v1",
"seed_version": "17",
"seed_version": "18",
"source_tag": "JVNAUTOSCI-2592",
"managed_by": "spreadsheet_programme_workflow_vontology_service",
"processing_authority_fingerprint": authority_fingerprint,
Expand Down
4 changes: 2 additions & 2 deletions src/backend/workflows/repo_seed_bundles/kr_materialisation_workflow_seed_bundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"family_id": "#V#kr_design_materialisation_workflow_family",
"managed_by": "kr_materialisation_workflow_vontology_service",
"schema_version": "repo_seed_workflow_bundle.v1",
"seed_version": "4",
"seed_version": "5",
"source_tag": "JVNAUTOSCI-2271",
"supported_action_ids": [
"llm.action",
Expand Down Expand Up @@ -718,7 +718,7 @@
{
"concept_id": "#V#workflow_mapping_tool_field_kr_design_concept_materialisation_item_workflow_attach_description_relation_id_to_kr_description_relation_id",
"context_key": "kr_description_relation_id",
"tool_output_field": "relation_id"
"tool_output_field": "kept_relation_id"
},
{
"concept_id": "#V#workflow_mapping_tool_field_kr_design_concept_materialisation_item_workflow_attach_description_text_value_id_to_kr_description_text_value_id",
Expand Down
20 changes: 10 additions & 10 deletions ...orkflows/repo_seed_bundles/spreadsheet_programme_representation_workflow_seed_bundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
"managed_by": "spreadsheet_programme_workflow_vontology_service",
"processing_authority_dependencies": {
"kr_materialisation_workflow_seed_bundle": {
"canonical_payload_sha256": "sha256:d01ea4c91f61802ebd4c8935d5e6d8c817f2f2559db495da965c38add43a0b33",
"canonical_payload_sha256": "sha256:89dd92a52fd395f8d3e464db1dded926d229d34318e1be2f898fd5e24b30a9e4",
"family_id": "#V#kr_design_materialisation_workflow_family",
"seed_version": "4"
"seed_version": "5"
}
},
"processing_authority_fingerprint": "sha256:4a23437988d6e745aac1a2515ed8b1231b8b3fb0f63abe078c107d176b74f79f",
"processing_authority_fingerprint": "sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3",
"schema_version": "repo_seed_workflow_bundle.v1",
"seed_version": "17",
"seed_version": "18",
"source_tag": "JVNAUTOSCI-2592",
"support_concepts": [
{
Expand Down Expand Up @@ -306,7 +306,7 @@
},
{
"key": "processing_authority_fingerprint",
"value": "sha256:4a23437988d6e745aac1a2515ed8b1231b8b3fb0f63abe078c107d176b74f79f"
"value": "sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3"
}
],
"tool_output_mapping_specs": [
Expand Down Expand Up @@ -702,7 +702,7 @@
},
{
"key": "processing_authority_fingerprint",
"value": "sha256:4a23437988d6e745aac1a2515ed8b1231b8b3fb0f63abe078c107d176b74f79f"
"value": "sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3"
}
],
"tool_output_mapping_specs": [
Expand Down Expand Up @@ -776,7 +776,7 @@
},
{
"key": "processing_authority_fingerprint",
"value": "sha256:4a23437988d6e745aac1a2515ed8b1231b8b3fb0f63abe078c107d176b74f79f"
"value": "sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3"
}
],
"tool_output_mapping_specs": [
Expand Down Expand Up @@ -1234,7 +1234,7 @@
},
{
"key": "processing_authority_fingerprint",
"value": "sha256:4a23437988d6e745aac1a2515ed8b1231b8b3fb0f63abe078c107d176b74f79f"
"value": "sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3"
}
],
"tool_output_mapping_specs": [
Expand Down Expand Up @@ -1557,7 +1557,7 @@
},
{
"key": "processing_authority_fingerprint",
"value": "sha256:4a23437988d6e745aac1a2515ed8b1231b8b3fb0f63abe078c107d176b74f79f"
"value": "sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3"
}
],
"tool_output_mapping_specs": [
Expand Down Expand Up @@ -1625,7 +1625,7 @@
},
{
"key": "processing_authority_fingerprint",
"value": "sha256:4a23437988d6e745aac1a2515ed8b1231b8b3fb0f63abe078c107d176b74f79f"
"value": "sha256:9f32be33af418e0c6aba292882ce87531d49632cc43d5352398b7f30bb24fff3"
}
],
"tool_output_mapping_specs": [
Expand Down
10 changes: 9 additions & 1 deletion tests/backend/test_kr_materialisation_workflow_vontology_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def test_kr_prompt_seed_assets_hold_operational_prompt_content() -> None:

def test_kr_seed_applies_optional_guard_before_each_write_phase() -> None:
bundle = json.loads(_SEED_BUNDLE_PATH.read_text(encoding="utf-8"))
assert bundle["seed_version"] == "4"
assert bundle["seed_version"] == "5"
workflow = next(
row
for row in bundle["workflows"]
Expand Down Expand Up @@ -231,6 +231,14 @@ def test_kr_seed_applies_optional_guard_before_each_write_phase() -> None:
)
for binding in concept_item_states["create_concept"]["static_input_bindings"]
)
description_outputs = {
row["context_key"]: row["tool_output_field"]
for row in concept_item_states["attach_description"][
"tool_output_mapping_specs"
]
}
assert description_outputs["kr_description_relation_id"] == "kept_relation_id"
assert description_outputs["kr_description_text_value_id"] == "text_value_id"
concept_iteration_bindings = dict(
states["materialise_concepts"]["static_input_bindings"]
)
Expand Down
4 changes: 2 additions & 2 deletions tests/backend/test_spreadsheet_programme_workflow_vontology_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ def test_processing_authority_fingerprint_tracks_exact_kr_dependency(
from scripts import generate_spreadsheet_programme_workflow_seed as generator

baseline = generator.build_bundle()
assert baseline["seed_version"] == "17"
assert baseline["seed_version"] == "18"
baseline_dependency = baseline["processing_authority_dependencies"][
"kr_materialisation_workflow_seed_bundle"
]
Expand All @@ -352,7 +352,7 @@ def test_processing_authority_fingerprint_tracks_exact_kr_dependency(
)
assert baseline_dependency["family_id"] == source_payload["family_id"]
assert baseline_dependency["seed_version"] == source_payload["seed_version"]
assert baseline_dependency["seed_version"] == "4"
assert baseline_dependency["seed_version"] == "5"
assert baseline_dependency["canonical_payload_sha256"].startswith("sha256:")

changed_payload = dict(source_payload)
Expand Down
Loading