Repository navigation
Complete mobile image picker and recoverable attachment lifecycle - #658
Merged
Merged
Conversation
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — mobile users can attach images beside the draft, review or replace previews, recover failed uploads, and submit each image with the intended request.
User outcome
Adds a direct image picker to the compact composer and completes the mobile attachment lifecycle. Builds on the merged screenshot-paste recovery in #693, preserving its clipboard helper and guidance without duplicate controls.
Material changes
Native task:
#V#task_agent_ca207e7d618fae369ec5b9c43f3e7741.Evidence
87f70a14f973ccedb1500b395ea554fb523dddb2: actual upload and original-byte/SHA-256 read-back, preview/removal/replacement, caption preservation, upload retry and next-request/conversation binding at 360, 412 and 1440 pixels.Evidence and limitations:
docs/engineering/otter_archive_and_conversation_images.md; retained results/screenshots in.run/image-picker-authenticated/and.run/image-picker-current/. The final commit changes only the acceptance harness and documentation after the tested product revision.Ship boundary
Minimum ship criteria are met: supported picker, recoverable attachment lifecycle, correct request binding, and authenticated local mobile/PWA-shell acceptance. Wrong attachment binding, lost drafts, upload failure without recovery or inaccessible narrow controls would block shipping; none remain in the affected tests.
Physical-device PWA installation, iOS, Chrome 152, vision-model answers, saved-history acceptance and offline uploads are not claimed. Native clipboard evidence does not claim original-byte fidelity or repair of Gboard keyboard-tile refusal. No public deployment is requested.