Repository navigation
Fix footer browser selectors after model pill grouping - #749
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #748 put the reasoning button inside the model pill, so the mobile-footer and native-zoom browser checks now match two buttons and fail Playwright's strict selector check when opening model settings. Select the pill's direct model button in all three affected clicks.
Validation: Chromium with the actual merged footer renderer/CSS and mocked APIs reproduces the old two-match failure, verifies that the replacement selects only the model button, and confirms both model and reasoning controls open settings. All 37 footer execution-status/preferences tests pass; both changed scripts pass syntax checks. Full authenticated mobile and native-zoom campaigns were not rerun for this selector-only repair. No deployment requested.
Manager review follow-up: #V#task_agent_942475d9a53e868bf06a39d637967ed1. No product-code changes.