Skip to content

Fix footer browser selectors after model pill grouping #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
witbrock merged 1 commit into from
Sep 17, 2026
Merged

Fix footer browser selectors after model pill grouping #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/browser/footerNativeZoom.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const key = (...args) => execFileSync(process.env.XDOTOOL || 'xdotool', args, {
await page.setViewportSize({ width: 360, height: 640 });
await check('narrow360', 1, true);
await page.locator('.mobile-footer-details > summary').click();
await page.locator('.conversation-model-controls button').click();
await page.locator('.conversation-model-controls > button').click();
await page.locator('.mobile-footer-details > summary').click();
await expect(page.frameLocator('#settingsFrame').locator('#premium-model-settings')).toBeVisible();
receipt.modelSettingsReachable = true;
Expand Down
4 changes: 2 additions & 2 deletions tests/browser/mobileFooter.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ async function measure(page, name) {
await expect(page.locator('.footer-container')).toBeHidden();
await measure(page, 'after-refresh');
await page.locator('.mobile-footer-details > summary').click();
await page.locator('.conversation-model-controls button').click();
await page.locator('.conversation-model-controls > button').click();
await page.locator('.mobile-footer-details > summary').click();
await expect(page.frameLocator('#settingsFrame').locator('#premium-model-settings')).toBeVisible();
const reasoningState = async p => {
Expand Down Expand Up @@ -149,7 +149,7 @@ async function measure(page, name) {
}
await desktop.locator('.footer-org-menu-trigger').click();
await expect(desktop.locator('.footer-org-options')).toBeVisible();
await control.locator('.conversation-model-controls button').click();
await control.locator('.conversation-model-controls > button').click();
await expect(control.frameLocator('#settingsFrame').locator('#premium-model-settings')).toBeVisible();
assert.deepEqual(await reasoningState(control), candidateReasoning);
fs.writeFileSync(path.join(evidence, 'result.json'), JSON.stringify({ sha, metrics, reasoningState: candidateReasoning, noSendsOrModelCalls: true, simulationLimits: 'Chromium viewport/touch simulation; no physical keyboard or public OAuth claim' }, null, 2));
Expand Down
Loading