Skip to content

Themes: faster tab and progress bar painting - #1084

Merged
SirSparkles merged 2 commits into
TV-Rename:masterfrom
kadeschs:themes-speed
Nov 17, 2026
Merged

SirSparkles merged 2 commits into
TV-Rename:masterfrom
kadeschs:themes-speed

Conversation

@kadeschs

Copy link
Copy Markdown
Collaborator

Hi Mark,

Following up on the snappiness in #1077. Found a couple things in the code that was slowing it down:

  1. The themed tab control redrew every tab each time any part of it repainted and one tab switch causes a lot of repaints. It now only redraws the tabs Windows asks for like the standard tab control.
  2. In Dark, the themed progress bar painted twice for every progress step which slowed TV Show Summary and the scan progress bar. It now paints once.

Light and Creme run at 5.2.7 speed and nothing looks different. Dark is still a little slower on tab switch and to open Preferences. I believe that part is the dark mode built into .NET's Windows Forms.

Try this out and see what you think.

TabControlThemed redrew every tab on every paint, and a tab switch causes
many paints. Only the tabs inside the area being repainted are drawn now.
In dark mode ProgressBarThemed painted twice per progress step; it paints
once now.
One declaration per line, and named constants for the tab margin and the pixel byte offsets. No change in behaviour.
@SirSparkles
SirSparkles merged commit 7a7a3ba into TV-Rename:master Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants