Repository navigation
Themes: faster tab and progress bar painting - #1084
Merged
Merged
Conversation
TabControlThemed redrew every tab on every paint, and a tab switch causes many paints. Only the tabs inside the area being repainted are drawn now. In dark mode ProgressBarThemed painted twice per progress step; it paints once now.
One declaration per line, and named constants for the tab margin and the pixel byte offsets. No change in behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mark,
Following up on the snappiness in #1077. Found a couple things in the code that was slowing it down:
Light and Creme run at 5.2.7 speed and nothing looks different. Dark is still a little slower on tab switch and to open Preferences. I believe that part is the dark mode built into .NET's Windows Forms.
Try this out and see what you think.