[lilyshen0722]

Written by Polish, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

Summary

• Show “Native engine” for agents whose runtime type is native, including Scout.
• Keep the existing Hosted label for hosted runtimes and the existing daemon and CLI labels.
• Add English and Chinese labels and a focused rendering check.

Verification

• V2AgentRuntimeGrants.test.tsx: 13/13 passed.
• Frontend tsc --noEmit: passed with worktree dependencies linked.
• Scoped ESLint: 0 errors (2 existing JSX extension warnings).
• git diff --check: clean.

TASK-460; D44 audit.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Team-Commonly/commonly
• Branch: main
• File: .coderabbit.yaml
• Commit: 5d1a67d
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: 8e9790da-8210-48dd-90bf-a6be4700ae9c

Commits

Reviewing files that changed from the base of the PR and between 832cc97 and 40df81e.

Files selected for processing: 4

• frontend/src/i18n/locales/en.json
• frontend/src/i18n/locales/zh-CN.json
• frontend/src/v2/__tests__/V2AgentRuntimeGrants.test.tsx
• frontend/src/v2/components/V2AgentRuntimeGrants.tsx

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The runtime summary now classifies native runtimes as a distinct mode and displays a translated “Native engine” label. English and Simplified Chinese translations and tests for classification and rendering were added.

Changes: Native Runtime Labeling

Layer / File(s)	Summary
Native runtime classification and label frontend/src/v2/components/V2AgentRuntimeGrants.tsx, frontend/src/i18n/locales/en.json, frontend/src/i18n/locales/zh-CN.json, frontend/src/v2/__tests__/V2AgentRuntimeGrants.test.tsx	describeRuntime returns native for native runtimes. The runtime label map and locale files provide the translated label. Tests check classification and rendered text.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Possibly related issues

• Full zh-CN language support + language switch in the top bar #709 — This PR adds a Simplified Chinese runtime label, which covers part of the issue’s localization work.

Possibly related PRs

• Team-Commonly/commonly#2527 — It introduced describeRuntime and the runtime-label behavior that this PR updates.

Merge Risk: Minimal · up to 40df8

Native runtimes now display the translated native label while existing runtime labels and controls remain supported.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: displaying the native engine label in agent Settings.
Description check		The description directly explains the native runtime label change, related translations, tests, and verification results.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 4
• Waived: $1.00 (charged $0.00)
• View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

_{Comment @coderabbitai help to get the list of available commands.}

[lilyshen0722]

#2593 TASK-460 at 832cc97 — CODE PASS

Settings reads installation.runtime.runtimeType into V2AgentRuntimeGrants. The new native branch precedes the host: cloud fallback, so native agents, including Scout, display “Native engine”; hosted, internal, daemon and CLI classification retain their prior paths. Both locale keys are present, and the focused render test checks the native label and absence of “Hosted”. I found no code blocker in this delta. The author reports 13/13 focused tests, frontend typecheck and scoped lint green; CI is still running and is a separate gate.

Written by Sable

Written by Sable, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

[lilyshen0722]

UX-GATE: PASS @ 832cc97
ux-lead render gate (Signal), on behalf of lily-shen's pod. I built the head and main locally (bf0bd59) and rendered the Settings Runtime section on a fixture with zero network: 0 aborted requests, 0 page errors, and the one harness miss is the same on both builds. The head bundle carries 原生引擎.

• A native seat (Scout's shape) shows "How it runs · Native engine" in en and "运行方式 · 原生引擎" in zh. Main showed "Hosted" / "托管运行". Section geometry matches main exactly: 912×144 at 1440 and 290×188 at 390. Nothing overflows, and scrollWidth equals clientWidth.
• A wrapper seat is byte-for-byte unchanged in text ("On a computer, via the daemon · Codex"). Per the code and the D44 audit's walk table, a Run it here agent (runtimeType: hosted, engine native) still reads "Hosted".

Non-blocking copy note: "engine" appears nowhere else in user-facing copy, so this row adds an internal word for what is really "Commonly runs this one itself". "Built into Commonly" / "Commonly 内置" says the same thing in the words the BYO chooser already uses ("on Commonly"). If you take it, it's a copy-only delta and I'll restamp quickly.

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

[lilyshen0722]

CODE PASS at 40df81e

Re-gated the checked-out merge head. The conflict resolution preserves main's managed === false wrapper classification as Single CLI, retains managed/default wrappers as daemon, and adds the previously reviewed native branch before the cloud-host fallback. Hosted/internal behavior is unchanged. Settings passes runtimeManaged into the component, so the preserved branch has its consumer data. Both English and Chinese native labels match the earlier reviewed head.

Compared with main parent 5d1a67d, the component is exactly main plus the native mode type, native classification branch and label-map entry. Compared with earlier PASS head 832cc97, its component/test changes are the inherited managed flag and unmanaged-wrapper assertion. No CSS or token files changed. No inline CodeRabbit threads were present at the final check.

Commands/checks run with Node 22:

• git fetch origin +pull/2593/head:refs/sable-review/2593
• git worktree add --detach /tmp/commonly-gate-2593-40df81e6 refs/sable-review/2593
• git fetch origin 832cc97
• git diff 5d1a67d...HEAD -- frontend/src/v2/components/V2AgentRuntimeGrants.tsx frontend/src/v2/tests/V2AgentRuntimeGrants.test.tsx frontend/src/i18n/locales/en.json frontend/src/i18n/locales/zh-CN.json
• git diff 832cc97 HEAD -- frontend/src/v2/components/V2AgentRuntimeGrants.tsx frontend/src/v2/tests/V2AgentRuntimeGrants.test.tsx
• Read the complete component, focused tests and Settings runtime consumer.
• Python assertions comparing the merged component to main plus the three native-label additions, and checking both locale values against the earlier head (pass).
• cd frontend && CI=true ./node_modules/.bin/jest --watchAll=false --runInBand src/v2/tests/V2AgentRuntimeGrants.test.tsx (13/13)
• cd frontend && ./node_modules/.bin/tsc --noEmit (pass)
• cd frontend && ./node_modules/.bin/eslint src/v2/components/V2AgentRuntimeGrants.tsx src/v2/tests/V2AgentRuntimeGrants.test.tsx (zero errors; two existing JSX extension warnings)
• git diff --check (clean)
• gh pr view 2593 --repo Team-Commonly/commonly --json headRefOid (matches reviewed SHA)

The initial npm test wrapper started a broad suite instead of forwarding the focused Jest arguments; it was interrupted and replaced by the direct focused Jest command above. This verdict does not claim a completed full-suite run or a browser render.

Credit: Polish conflict resolution and implementation; Sable code re-gate.

Written by Sable, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

[lilyshen0722]

UX-GATE: PASS @ 40df81e
ux-lead render gate (Signal), on behalf of lily-shen's pod. This is a re-gate with renders. The head moved from 832cc97 by a merge of main, and that merge resolved a conflict in V2AgentRuntimeGrants.tsx, so I did not carry the old stamp.

Code. en.json, zh-CN.json and the test have patch-ids identical to 832cc97 (7b7bbeee / a8eaa1be / 639b9ef8). The component's patch-id moved (8fdefb42 → 984d3f72), but the PR's added and removed lines are unchanged. The only difference is the context line from #2573 (type === 'wrapper' ? (runtime.managed === false ? 'cli' : 'daemon')), which now sits inside the hunk. The resolution keeps #2573's wrapper branch first and this PR's native branch second, so the unmanaged-wrapper case still reaches cli.

Renders. I built the head and its merge base 5d1a67d locally and rendered the Settings Runtime section on a zero-network fixture: 0 aborted requests, 0 page errors, and the same single harness miss on both builds. Only the head bundle contains 原生引擎.

• A native seat reads "How it runs · Native engine" (en) and "运行方式 · 原生引擎" (zh) at 1440 and at 390 zh. Base reads "Hosted" / "托管运行". Section geometry equals base and my earlier gate: 912×144 at 1440 and 290×188 at 390. Nothing overflows, and scrollWidth equals clientWidth.
• The wrapper seat (Codex) is unchanged: "On a computer, via the daemon · Codex", 912×266. Its PNG is byte-identical to a second render of the base build. The only head-vs-base pixel delta is in the native <select> text, and the same delta appears between two runs of the base build itself.

The non-blocking "engine" copy note from my 832cc97 review stands.

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS