Skip to content

Show native engine in agent Settings #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 2 commits into from
Oct 24, 2026
Merged

Show native engine in agent Settings #2593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832cc97
fix: show native engine in agent settings
lilyshen0722 Oct 24, 2026
40df81e
Merge remote-tracking branch 'origin/main' into polish/task-460-nativ…
lilyshen0722 Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2308,6 +2308,7 @@
"runtime": {
"title": "Runtime",
"how": "How it runs",
"native": "Native engine",
"hosted": "Hosted",
"daemon": "On a computer, via the daemon",
"cli": "Single CLI",
Expand Down
1 change: 1 addition & 0 deletions frontend/src/i18n/locales/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2299,6 +2299,7 @@
"runtime": {
"title": "运行环境",
"how": "运行方式",
"native": "原生引擎",
"hosted": "托管运行",
"daemon": "通过守护进程在电脑上运行",
"cli": "单个 CLI",
Expand Down
7 changes: 7 additions & 0 deletions frontend/src/v2/__tests__/V2AgentRuntimeGrants.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,16 @@ test('runtime labels only recognize walked adapters and distinguish daemon from
expect(describeRuntime({ runtimeType: 'webhook', host: 'byo', adapter: 'dsh' })).toEqual({ mode: 'cli', adapter: 'DeepSeek Harness' });
expect(describeRuntime({ runtimeType: 'wrapper', adapter: 'unwalked' })).toEqual({ mode: 'daemon', adapter: null });
expect(describeRuntime({ runtimeType: 'hosted' })).toEqual({ mode: 'hosted', adapter: null });
expect(describeRuntime({ runtimeType: 'native', host: 'cloud' })).toEqual({ mode: 'native', adapter: null });
expect(describeRuntime({ runtimeType: 'webhook', host: 'byo' })).toEqual({ mode: 'unknown', adapter: null });
});

test('shows the native engine for a native agent', async () => {
renderSection({ runtimeType: 'native' });
expect(await screen.findByText('Native engine')).toBeInTheDocument();
expect(screen.queryByText('Hosted')).not.toBeInTheDocument();
});

test('revoked Runtime row offers an active computer and moves in one request', async () => {
axios.get.mockImplementation((url) => Promise.resolve({ data: url.includes('/agent-binding/placement')
? { boundMachineId: 'old', requestedMachineId: null, boundMachineRevoked: true,
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/v2/components/V2AgentRuntimeGrants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,12 @@ const WALKED_ADAPTERS: Record<string, string> = {
};
const DAEMON_SETUP_COMMAND = 'npm i -g @commonlyai/cli@latest && commonly login && commonly daemon register && commonly daemon install';

export const describeRuntime = (runtime: Runtime): { mode: 'hosted' | 'daemon' | 'cli' | 'unknown'; adapter: string | null } => {
export const describeRuntime = (runtime: Runtime): { mode: 'native' | 'hosted' | 'daemon' | 'cli' | 'unknown'; adapter: string | null } => {
const type = String(runtime.runtimeType || '').toLowerCase();
const adapterKey = String(runtime.adapter || type).toLowerCase();
const mode = type === 'wrapper' ? (runtime.managed === false ? 'cli' : 'daemon')
: type === 'hosted' || type === 'native' || type === 'internal' || runtime.host === 'cloud' ? 'hosted'
: type === 'native' ? 'native'
: type === 'hosted' || type === 'internal' || runtime.host === 'cloud' ? 'hosted'
: runtime.host === 'byo' && WALKED_ADAPTERS[adapterKey] ? 'cli' : 'unknown';
return { mode, adapter: WALKED_ADAPTERS[adapterKey] || null };
};
Expand Down Expand Up @@ -142,6 +143,7 @@ const V2AgentRuntimeGrants: React.FC<Props> = ({

const details = useMemo(() => describeRuntime(runtime), [runtime]);
const modeLabel = {
native: t('agentManage.runtime.native', { defaultValue: 'Native engine' }),
hosted: t('agentManage.runtime.hosted', { defaultValue: 'Hosted' }),
daemon: t('agentManage.runtime.daemon', { defaultValue: 'On a computer, via the daemon' }),
cli: t('agentManage.runtime.cli', { defaultValue: 'Single CLI' }),
Expand Down
Loading