Skip to content

docs: unlist the Hermes BYO page; keep DeepSeek Harness on its walk record (TASK-017) - #2793

Merged
lilyshen0722 merged 1 commit into
mainfrom
task-017-byo-walk-record
Oct 27, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
task-017-byo-walk-record

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Quire, a Commonly agent — https://commonly.me/v2/pods/6aaee2af1e8446ae11fb1457

TASK-017 — Bring your own pages: walk record decides each one

Tier 0, docs only (plus one unit-test list). The README already dropped Hermes and DeepSeek Harness; the docs site still published both BYO pages. Each page stays only with a dated walk record linked here.

DeepSeek Harness: kept

  • In-repo walk record: docs/cli/dsh.md (lines 82–83): walked with a non-admin Commonly account on macOS with CLI 0.1.117, then re-walked on CLI 0.1.122 on 2026-10-23. The page names CLI 0.1.122 and dsh 0.2.1-rc.2, which match the re-walk.
  • Merged PR fix(scout): guide DeepSeek Harness connection #2404 (fix(scout): guide DeepSeek Harness connection) records the same non-admin macOS walk.
  • Gap, for GTM to rule on: neither record cites a pod message in which an @mention was answered. The walk record shows the attach and run path, not the reply. If the press needs the reply cited, the page needs a message ID from the re-walk.

Hermes: unlisted

  • The only Hermes walk on record is PA-1, cited in PR fix(scout): list Hermes as a command-line connect, with its walk and caveats (TASK-429) #2569's body (10-22 16:30Z, @mention answered in 56 s). That walk does not cover this page:
    • it ran on a commit before the probe fix (the PR body says so);
    • it used a provider other than OpenRouter, while the page tells the reader to use an OpenRouter key.
  • Removed: the page file, its nav entry, and its card on the Bring your own index. The index description no longer names Hermes.
  • To restore: re-walk on the current head with the setup the page describes, then put that record in the PR body.

Test

backend/__tests__/unit/scripts/docsSiteFacts.test.js: Hermes moves from the required nav list to the not-listed list, so the test enforces the unlist.

Verification

  • npx jest __tests__/unit/scripts/docsSiteFacts.test.js (Node 26 locally): 6/6 pass.
  • node --check on the test file and git diff --check: pass.
  • docs-site/docs.json parses.
  • cd docs-site && npx -y mint@4.2.1028 broken-links: no broken links.
  • grep -rn hermes docs-site: no references remain.

Not changed

  • frontend/public/llms.txt has no Hermes or DeepSeek Harness line, so nothing came off it.
  • The in-app BYO copy belongs to TASK-012.

🤖 Generated with Claude Code

…ecord (TASK-017)

The Hermes page names an OpenRouter key. The only Hermes walk on record
(PA-1, PR #2569 body, 10-22 16:30Z) ran on a different provider and on a
commit before the probe fix, so it does not walk the page's setup.
Remove the page from nav, the BYO index card and the file, and move
Hermes to the unlisted set in the docs fact test.

DeepSeek Harness stays: docs/cli/dsh.md records the non-admin macOS walk on
0.2.1-rc.2 (CLI 0.1.117) and the re-walk on CLI 0.1.122 on 2026-10-23, and
PR #2404 records the same walk.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: quire <WyJxdWlyZSIsImRlZmF1bHQiXQ@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/high
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 31289b5 and 6b6e3af.

Files selected for processing: 4
  • backend/__tests__/unit/scripts/docsSiteFacts.test.js
  • docs-site/bring-your-own/hermes.mdx
  • docs-site/bring-your-own/index.mdx
  • docs-site/docs.json
Files with no reviewable changes: 2
  • docs-site/docs.json
  • docs-site/bring-your-own/hermes.mdx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

The Hermes Bring Your Own Agent guide was deleted. Its page description, guide card, and navigation entry were removed. The navigation test now expects Hermes to be absent.

Changes: Hermes BYO documentation

Layer / File(s) Summary
Remove Hermes guide and listings
docs-site/bring-your-own/hermes.mdx, docs-site/bring-your-own/index.mdx, docs-site/docs.json, backend/__tests__/unit/scripts/docsSiteFacts.test.js
The Hermes setup guide and its references were removed. The navigation test now checks that Hermes is absent.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 6b6e3

No actionable merge-blocking risk remains in this documentation-only change.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly summarizes the main documentation change: removing the Hermes BYO page while retaining the DeepSeek Harness page based on its walk record.
Description check Passed The description directly explains the Hermes removal, the DeepSeek Harness decision, the test changes, and the reported verification results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 26, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 26, 2026
@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 4124ec5 Oct 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant