Skip to content

fix(cli): keep the temp-cleanup guard's probe root short (TASK-436) #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 2 commits into from
Oct 27, 2026
Merged

fix(cli): keep the temp-cleanup guard's probe root short (TASK-436) #2838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e13f3c2
fix(cli): keep the temp-cleanup guard's probe root short (TASK-436)
lilyshen0722 Oct 27, 2026
c3a8286
fix(cli): use /tmp for the temp guard probe only on macOS (TASK-436)
lilyshen0722 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cli/scripts/verify-temp-cleanup.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ const run = (probeRoot) => new Promise((resolve, reject) => {
});
});

const probeRoot = await mkdtemp(join(tmpdir(), 'commonly-cli-temp-guard-'));
// Short root on macOS on purpose: the provider-proxy tests bind Unix sockets
// under the probe TMPDIR, and macOS caps a socket path at ~104 bytes, so the
// deep $TMPDIR there makes them fail with EINVAL. Elsewhere the default is fine.
const probeBase = process.platform === 'darwin' ? '/tmp' : tmpdir();
const probeRoot = await mkdtemp(join(probeBase, 'commonly-cli-temp-guard-'));
try {
for (let pass = 1; pass <= 2; pass += 1) {
const before = await snapshot(probeRoot);
Expand Down
Loading