Skip to content

copy(landing): Enterprise strip marks SSO/SAML planned, drops federation - #2856

Merged
lilyshen0722 merged 1 commit into
mainfrom
gtm/enterprise-strip-sso-planned
Oct 27, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
gtm/enterprise-strip-sso-planned

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Summary

Tier 0/1 copy fix, requested by CTO on 10-27 ahead of the D116 enterprise ADR. The landing Enterprise strip (landing.pricing.enterprise.text, rendered at frontend/src/v2/landing/V2LandingPage.tsx:887) promised two things main can't back:

Claim Verdict Evidence
"SSO/SAML" FALSE today → marked planned `git grep -i -E 'saml
"federation across instances" Unverified → cut Cross-pod queries work within one instance; no cross-instance walk exists.
"private or dedicated deployment, SLAs, and a security review" Kept Self-host exists; SLAs and the review are sales commitments, not product claims.

en: — private or dedicated deployment, SLAs, and a security review. SSO/SAML is planned.
zh-CN: — 私有或专属部署、SLA 和安全评审。SSO/SAML 已在计划中。 (Latin–CJK spacing follows the file's existing style.)

Strings review: vera. No dates are promised for SSO.

Type

  • Copy

🤖 Generated with Claude Code

https://claude.ai/code/session_01MDs9DQ4A4V1Vdp54isbxo5

…nstance federation

origin/main has no SAML or generic OIDC sign-in (GitHub and Google OAuth only),
and federation across instances is not verified (PodLink is within one instance).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MDs9DQ4A4V1Vdp54isbxo5
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between bdd7c0f and 4ef66bf.

Files selected for processing: 2
  • frontend/src/i18n/locales/en.json
  • frontend/src/i18n/locales/zh-CN.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

The English and Simplified Chinese Enterprise pricing descriptions no longer list cross-instance federation as included. Both describe SSO/SAML as planned.

Changes: Enterprise pricing copy

Layer / File(s) Summary
Update localized Enterprise descriptions
frontend/src/i18n/locales/en.json, frontend/src/i18n/locales/zh-CN.json
Both descriptions remove cross-instance federation from the listed features and describe SSO/SAML as planned.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related issues

  • Team-Commonly/commonly issue 709 — This PR updates Simplified Chinese Enterprise pricing copy, but does not implement full Simplified Chinese landing-page support.

Possibly related PRs

Merge Risk: Minimal · up to 4ef66

The Enterprise copy is consistent across the two changed languages, with no established issue blocking merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly summarizes the main copy change: it marks SSO/SAML as planned and removes federation from the Enterprise strip.
Description check Passed The description directly explains the Enterprise strip copy changes, the affected locales, and the rationale for each claim.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings gate for #2856 at 4ef66bf (Tier 1). Files: en.json, zh-CN.json.

Removed promises are gone from the whole tree. git grep -iE 'SAML|federation across|跨实例|联邦' across the head, excluding docs/ and tests, matches only these two locale lines. No landing source or README still carries the old Enterprise copy.

The promises that remain can be backed today:

  • Private or dedicated deployment: the self-host chart and compose exist.
  • A security review: this promises a process, not a certification. The line makes no SOC 2 or ISO claim.
  • SLAs: I checked this one before agreeing it is a sales commitment. An SLA needs measured uptime, and we have that now. Cloud Monitoring has paged on commonly-dev since 10-14 (docs/runbooks/alerting.md, k8s/monitoring/alert-policies.json), and the Uptime Check cron probes commonly.me and api.commonly.me/api/health (latest run green at 06:10Z). The readiness plan's "no alerting" line (docs/plans/production-readiness-and-selling-2026-09-11.md:25) is out of date.
  • No date is promised for SSO.

zh-CN passes the glossary and style rules. No 你/您 pronoun appears. 企业版 and 私有部署 are used in their reserved enterprise sense, and SSO/SAML and SLA stay English as the glossary requires. There is a half-width space at each CJK–Latin boundary (SLA 和, SSO/SAML 已) and none next to full-width punctuation (、SLA, 。SSO). The plural "SLAs" correctly maps to the bare term, and there are no banned calques. One optional wording: 规划中 reads a little more like product copy than 已在计划中. That is not a defect.

Both files parse, and landing.pricing.enterprise.text resolves in each. No defects.

Written by Vera, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015

GATE: PASS 4ef66bf — the old SSO/federation promises are gone tree-wide, each remaining promise has a backing today (SLAs are now measured), and zh-CN passes the glossary, 你 rule and CJK–Latin spacing

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit bafad40 Oct 27, 2026
26 checks passed
samxu01 pushed a commit that referenced this pull request Oct 27, 2026
Walked the Pricing section against main and removed or scoped the claims
the code does not back:
- "10 hosted agent seats" and "coming soon": the default is 1 hosted agent
  per user on every plan, and hosted agents are live.
- "SSO/SAML" and "federation across instances": no SSO code on main, and
  federation is cross-pod inside one instance.
- "30 days of message history" is a ceiling, not a guarantee.
- "Pro adds hosted agents": Cloud free gets hosted agents too. Pro gets a
  higher turn cap (200 vs 30 a day per agent).
- "Pro adds unlimited history" now says "in pods you create": the pod's
  creator governs retention, not any member.

The enterprise line keeps main's "SSO/SAML is planned" (#2856). The guard
allows that phrase and no other SSO/SAML copy.

Adds a guard test for the scoped history line, and Pricing verdict rows in
docs/audits/claim-table.md. The zh-CN wording is a draft for GTM review.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/max
samxu01 pushed a commit that referenced this pull request Oct 27, 2026
Walked the Pricing section against main and removed or scoped the claims
the code does not back:
- "10 hosted agent seats" and "coming soon": the default is 1 hosted agent
  per user on every plan, and hosted agents are live.
- "SSO/SAML" and "federation across instances": #2856 (bafad40)
  already changed both in the pricing copy on main. There is no SSO
  code, and federation is cross-pod inside one instance.
- "30 days of message history" is a ceiling, not a guarantee.
- "Pro adds hosted agents": Cloud free gets hosted agents too. Pro gets a
  higher turn cap (200 vs 30 a day per agent).
- "Pro adds unlimited history" now says "in pods you create": the pod's
  creator governs retention, not any member.

The enterprise line keeps main's "SSO/SAML is planned" (#2856). The guard
allows that phrase and no other SSO/SAML copy.

Adds a guard test for the scoped history line, and Pricing verdict rows in
docs/audits/claim-table.md. The zh-CN wording is a draft for GTM review.

Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/max
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
samxu01 pushed a commit that referenced this pull request Oct 27, 2026
Walked the Pricing section against main and removed or scoped the claims
the code does not back:
- "10 hosted agent seats" and "coming soon": the default is 1 hosted agent
  per user on every plan, and hosted agents are live.
- "SSO/SAML" and "federation across instances": #2856 (bafad40)
  already changed both in the pricing copy on main. There is no SSO
  code, and federation is cross-pod inside one instance.
- "30 days of message history" is a ceiling, not a guarantee.
- "Pro adds hosted agents": Cloud free gets hosted agents too. Pro gets a
  higher turn cap (200 vs 30 a day per agent).
- "Pro adds unlimited history" now says "in pods you create": the pod's
  creator governs retention, not any member.

The enterprise line keeps main's "SSO/SAML is planned" (#2856). The guard
allows that phrase and no other SSO/SAML copy.

Adds guard tests for the scoped history line and the hosted-agent turn
caps (200 and 30 a day per agent, both locales), and Pricing verdict rows
in docs/audits/claim-table.md. The zh-CN wording is a draft for GTM review.

Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/max
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant