Skip to content

fix(legal): link the Terms and Privacy pages from the landing footer and signup (TASK-530) - #2907

Closed
lilyshen0722 wants to merge 1 commit into
mainfrom
swift/task-530-legal-links
Closed

lilyshen0722 wants to merge 1 commit into
mainfrom
swift/task-530-legal-links

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Summary

  • Lumen's row-2 walk at 8e0b7ae returned HOLD. /terms and /privacy render, but nothing links to them. The landing footer's legal column held only the license, and the signup form had no link.
  • This adds both. The footer links /terms and /privacy. The signup form links them under the sign-in hint.
  • en and zh-CN keys are added for each label.

Tests

  • V2Register.test.tsx: a new case asserts the two signup links point at /terms and /privacy. The register, landing and i18n suites pass (48/48 across the register and i18n files).
  • Lint: 0 errors. The three warnings are the existing jsx-filename-extension rule.

Not done here

  • 390/1440 screenshots of the footer and signup links are not attached. Headless login cannot reach the signed-in views.

Written by Swift, a Commonly agent (TASK-530 pod thread).

🤖 Generated with Claude Code

…and signup (TASK-530)

The /terms and /privacy routes shipped in #2709, but nothing on the site
linked to them. The landing footer's legal column held only the license,
and the signup form had no link. Add both: footer links to /terms and
/privacy, and the signup form links to them under the sign-in hint.

en and zh-CN keys added for each. A signup test asserts the links.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: swift <WyJzd2lmdCIsImRlZmF1bHQiXQ@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/default
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The registration page and landing-page footer now link to /terms and /privacy. English and Chinese translations provide labels for the links, and a registration test checks their destinations.

Changes: Legal links

Layer / File(s) Summary
Registration links and translations
frontend/src/v2/components/V2Register.tsx, frontend/src/v2/__tests__/V2Register.test.tsx, frontend/src/i18n/locales/en.json, frontend/src/i18n/locales/zh-CN.json
The registration page adds translated Terms and Privacy links to /terms and /privacy. A test checks both destinations.
Landing-page footer links and translations
frontend/src/v2/landing/V2LandingPage.tsx, frontend/src/i18n/locales/en.json, frontend/src/i18n/locales/zh-CN.json
The footer adds translated links to /terms and /privacy.

Priority: Not assessed

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Possibly related issues

Possibly related PRs

Merge Risk: Low · up to bcec6

The links work today, but future footer destination regressions could go undetected.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #2908, which opened two minutes later with the same footer links. #2908 is the one going forward because it carries the signup line Launch asked for ("By creating an account you agree to the Terms and Privacy policy") and a footer render test, and ux-lead's gate is already asked on it. Thanks for catching row 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant