Repository navigation
chore(helm): allowlist the walk user for the hidden Atlassian connector (D153) - #2914
Conversation
…walk (D153) Atlassian has been hidden since the 10-23 deploy because it had not been walked end to end. This adds the designated walk user to its exception, the same way #2655 did for Sentry, so the walk can run on the next deploy. Every other account still gets no offering and 404 unknown_entry. Sentry's exception is unchanged. Rendered: HOSTED_MCP_HIDDEN_ENTRY_USER_ALLOWLIST now carries airtable, atlassian and sentry, each with the one walk user, and every key is in hiddenEntries, so the map stays valid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MDs9DPbsFurockEzieszpM
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Atlassian allowlist configuration k8s/helm/commonly/values-dev.yaml |
The allowlist includes the specified Mongo user for Atlassian. The comment states that Atlassian and Sentry remain hidden for other accounts. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- Team-Commonly/commonly#2649: Adds the allowlist contract that this change configures for Atlassian.
- Team-Commonly/commonly#2655: Applies the same named-user exception pattern to hidden Sentry.
- Team-Commonly/commonly#2530: Adds Atlassian to the hidden entries that this change keeps hidden for other accounts.
Merge Risk: 
Minimal · up to e642c
-
The configuration-only change is ready to merge, pending the intended Dev deployment.
Pre-merge checks: 
4
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
lilyshen0722
left a comment
There was a problem hiding this comment.
Connector-ops lane review at e642c03. values-dev only: atlassian is added to hostedMcp.hiddenEntryUserAllowlist with the same single walk user as sentry and airtable, so Atlassian stays hidden for every other account. It is the walk user the Cofounder designated on 10-24, which keeps the walk off Sam's account. No template change. Stack reports helm template renders a valid map for backend and ops-runner, and Chart Lint decides that in CI.
GATE: PASS
lilyshen0722
left a comment
There was a problem hiding this comment.
Code gate at e642c03. Merge base 9e9fada, 0 behind main. The PR touches one file, k8s/helm/commonly/values-dev.yaml: +3 −1.
- Same user as sentry. The new
atlassianentry is["6a47891ee025ce2e0ca1d30b"], byte-for-byte the id onsentry(and onairtable). - The key is the catalogue id.
backend/integrations/hostedMcp/atlassian.ts:53declaresid: 'atlassian', andatlassianis already inhostedMcp.hiddenEntries. That matters becausevisibility.tsallowedHiddenEntryUsersis all-or-nothing. If any key is missing from the hidden list, or fails/^[a-z0-9][a-z0-9-]*$/, the whole map is voided, sentry and airtable included. - Nothing else moved. I rendered the chart (
helm template … -f values-dev.yaml) at the base and at the head and diffed all 5,206 lines. Exactly two lines differ: theHOSTED_MCP_HIDDEN_ENTRY_USER_ALLOWLISTvalue on the backend and on ops-runner. At the head it is{"airtable":[id],"atlassian":[id],"sentry":[id]}.HOSTED_MCP_HIDDEN_ENTRIESis identical at both. - Behaviour. I ran this head's
isHostedMcpEntryHiddenagainst the rendered env from each render:- atlassian: hidden for everyone at the base. At the head it is shown to the walk user and still hidden for any other user and for an anonymous caller.
- sentry and airtable: unchanged (walk user shown, others hidden).
- notion: hidden for all at both.
- Control: adding a mis-cased
Atlassiankey to the same map hides sentry from the walk user too, so this probe can see a voided map.
The comment edit is accurate. Chart Lint and the stale-base guard are green. Backend, service, frontend, CLI and kind runs were still in progress when I filed, and none of them reads values-dev.
No defects found.
Written by Vera, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015
GATE: PASS
Atlassian has been hidden since the 10-23 deploy because nobody had walked it end to end. This adds the walk user, lily-shen, to Atlassian's exception, the same way #2655 did for Sentry, so the walk can run after the next deploy (D153).
What changes
k8s/helm/commonly/values-dev.yaml:hostedMcp.hiddenEntryUserAllowlistgainsatlassian: [lily-shen's User._id]. Sentry's and Airtable's exceptions are unchanged.hiddenEntries, so every other account still gets no offering and404 unknown_entry.Checked
helm templatewithvalues.yaml+values-dev.yamlrendersHOSTED_MCP_HIDDEN_ENTRY_USER_ALLOWLISTas{"airtable":[…],"atlassian":[…],"sentry":[…]}on both backend and ops-runner.hiddenEntries, sovisibility.tsaccepts the map. One stale key would void every exception.docs/runbooks/hosted-mcp-hidden-entry-walks.md) says to remove the ID and deploy again, or removeatlassianfromhiddenEntriesif the walk passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01MDs9DPbsFurockEzieszpM