Skip to content

fix(registry): hosted greeting names a mention handle only in team pods (TASK-376) - #2975

Merged
lilyshen0722 merged 1 commit into
mainfrom
task-376-greeting-mention
Oct 30, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
task-376-greeting-mention

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Wisp, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

Summary

  • The hosted agent's first-contact greeting told the person to "Mention me as @handle" in every pod. In a personal pod (agent-room, agent-dm, agent-admin) every plain reply is auto-routed, so that line was false there. Measured in pod chat: a plain reply in the room was answered in about 6 s.
  • Pass mentionHandle to the greeting only when the pod is not personal. Team pods still get the line, because there only an @mention reaches the agent.

Test plan

  • registry.install-hosted-greeting.test.js: new case, agent-room gets no mentionHandle and keeps hostedAgentUserId.
  • firstContactService.test.js unchanged and green.
  • Both suites: 30 passed.

Tracks TASK-376.

…ds (TASK-376)

A personal pod (agent-room, agent-dm, agent-admin) auto-routes every plain
reply to the agent, so the first-contact greeting's "Mention me as @handle"
line was false there. Pass mentionHandle only when the pod is not personal.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: wisp <WyJ3aXNwIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/default
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between eea6989 and 8ec7ceb.

Files selected for processing: 2
  • backend/__tests__/unit/routes/registry.install-hosted-greeting.test.js
  • backend/routes/registry/install.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The hosted install handler now omits mentionHandle from first-contact payloads when the hosted agent greets itself in a personal pod. A unit test checks this behavior for a personal agent-room.

Changes: Hosted Greeting

Layer / File(s) Summary
Personal pod greeting payload
backend/routes/registry/install.ts, backend/__tests__/unit/routes/registry.install-hosted-greeting.test.js
The handler includes mentionHandle for self-greetings only in non-personal pods. The test checks that a personal agent-room first-contact payload includes the hosted agent user ID and omits mentionHandle.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 8ec7c

No actionable merge-blocking risk remains after the coverage concern was resolved.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the actual change: the hosted first-contact greeting includes a mention handle only in team pods. It also carries the fix(registry) scope and the TASK-376 reference. It is specific and…
Description check Passed The description states the problem: the greeting told users to mention the agent in every pod, which is false in personal pods because plain replies are auto-routed there. It states the fix: pass ment…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the actual change: the hosted first-contact greeting includes a mention handle only in team pods. It also carries the fix(registry) scope and the TASK-376 reference. It is specific and matches the changeset, which adds a non-personal pod condition in backend/routes/registry/install.ts and a matching test.

Full details: Description check

Explanation

The description states the problem: the greeting told users to mention the agent in every pod, which is false in personal pods because plain replies are auto-routed there. It states the fix: pass mentionHandle only when the pod is not personal. It also lists the new agent-room test case and the test results. This matches the install.ts and test file changes.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of #2975 at 8ec7ceb (TASK-376).

Every pod type checked. Pod.type enum: chat, study, games, agent-ensemble, agent-admin, agent-room, agent-dm, team. The handle is now withheld only for PERSONAL_POD_TYPES (agent-admin, agent-room, agent-dm), which is the auto-routing set in podTypePolicyService. The other five keep the handle. pod is in scope at the call site (it is fetched with Pod.findById(podId).lean(), so type is present), and isPersonalPodType(undefined) returns false, so a missing pod keeps the old behaviour.

Handle still reaches the greeting where it is needed. firstContactService lowercases mentionHandle and only then emits mentionLineCue when MENTION_HANDLE matches, so the omission flows through cleanly.

Defects: none blocking.

  • The new test covers agent-room only. agent-dm and agent-admin have no case, though both sit in the set that drives the change. A parameterised case would pin the set.
  • I did not check whether agent-ensemble auto-routes plain replies. It is outside the personal set, so it keeps the handle. That matches the policy comment, but I checked the policy, not the routing.

Written by Lark, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 5fa77ba Oct 30, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant