Repository navigation
fix(registry): hosted greeting names a mention handle only in team pods (TASK-376) - #2975
Conversation
…ds (TASK-376) A personal pod (agent-room, agent-dm, agent-admin) auto-routes every plain reply to the agent, so the first-contact greeting's "Mention me as @handle" line was false there. Pass mentionHandle only when the pod is not personal. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Co-authored-by: wisp <WyJ3aXNwIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-haiku-5-5/default
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Personal pod greeting payload backend/routes/registry/install.ts, backend/__tests__/unit/routes/registry.install-hosted-greeting.test.js |
The handler includes mentionHandle for self-greetings only in non-personal pods. The test checks that a personal agent-room first-contact payload includes the hosted agent user ID and omits mentionHandle. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Merge Risk: 
Minimal · up to 8ec7c
-
No actionable merge-blocking risk remains after the coverage concern was resolved.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title names the actual change: the hosted first-contact greeting includes a mention handle only in team pods. It also carries the fix(registry) scope and the TASK-376 reference. It is specific and matches the changeset, which adds a non-personal pod condition in backend/routes/registry/install.ts and a matching test.
Full details: Description check
-
Explanation
The description states the problem: the greeting told users to mention the agent in every pod, which is false in personal pods because plain replies are auto-routed there. It states the fix: pass mentionHandle only when the pod is not personal. It also lists the new agent-room test case and the test results. This matches the install.ts and test file changes.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
lilyshen0722
left a comment
There was a problem hiding this comment.
Review of #2975 at 8ec7ceb (TASK-376).
Every pod type checked. Pod.type enum: chat, study, games, agent-ensemble, agent-admin, agent-room, agent-dm, team. The handle is now withheld only for PERSONAL_POD_TYPES (agent-admin, agent-room, agent-dm), which is the auto-routing set in podTypePolicyService. The other five keep the handle. pod is in scope at the call site (it is fetched with Pod.findById(podId).lean(), so type is present), and isPersonalPodType(undefined) returns false, so a missing pod keeps the old behaviour.
Handle still reaches the greeting where it is needed. firstContactService lowercases mentionHandle and only then emits mentionLineCue when MENTION_HANDLE matches, so the omission flows through cleanly.
Defects: none blocking.
- The new test covers
agent-roomonly.agent-dmandagent-adminhave no case, though both sit in the set that drives the change. A parameterised case would pin the set. - I did not check whether
agent-ensembleauto-routes plain replies. It is outside the personal set, so it keeps the handle. That matches the policy comment, but I checked the policy, not the routing.
Written by Lark, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
GATE: PASS
Written by Wisp, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
Summary
agent-room,agent-dm,agent-admin) every plain reply is auto-routed, so that line was false there. Measured in pod chat: a plain reply in the room was answered in about 6 s.mentionHandleto the greeting only when the pod is not personal. Team pods still get the line, because there only an @mention reaches the agent.Test plan
registry.install-hosted-greeting.test.js: new case, agent-room gets nomentionHandleand keepshostedAgentUserId.firstContactService.test.jsunchanged and green.Tracks TASK-376.