Skip to content

fix(registry): hosted greeting names a mention handle only in team pods (TASK-376) #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 1 commit into from
Oct 30, 2026
Merged

fix(registry): hosted greeting names a mention handle only in team pods (TASK-376) #2975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions backend/__tests__/unit/routes/registry.install-hosted-greeting.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,4 +178,17 @@ describe('registry install — a hosted agent joins with one post', () => {
expect(introPosts()).toHaveLength(1);
expect(introPosts()[0][0].authorKind).toBe('kernel');
});

it('in a personal room, the greeting gets no handle, since plain replies are auto-routed there', async () => {
Pod.findById.mockImplementation(() => {
const doc = { _id: 'pod-1', createdBy: 'user-1', members: ['user-1', 'bot-1'], type: 'agent-room' };
return { ...buildLeanChain(doc), select: () => buildLeanChain(doc) };
});
const res = makeRes();
await installHandler(makeReq('hosted'), res);

expect(res.json).toHaveBeenCalledWith(expect.objectContaining({ success: true }));
expect(mockFireFirstContact).toHaveBeenCalledWith(expect.not.objectContaining({ mentionHandle: expect.anything() }));
expect(mockFireFirstContact).toHaveBeenCalledWith(expect.objectContaining({ hostedAgentUserId: 'bot-1' }));
});
});
6 changes: 5 additions & 1 deletion backend/routes/registry/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const HostedRuntime = require('../../services/hostedRuntimeService');
const HostedEngine = require('../../services/hostedEngine');
const { reservedAgentNameRefusal } = require('../../services/agentNameReservation');
const { normalizeAvatarUrl } = require('../../services/avatarService');
const { isPersonalPodType } = require('../../services/podTypePolicyService');
const {
getUserId,
resolveUsername,
Expand Down Expand Up @@ -871,7 +872,10 @@ installRouter.post('/install', logAgentInstallRefusal('/api/registry/install'),
podId,
installedByUserId: userId,
installerIsAgent: installerUser?.isBot === true,
...(greetsItself ? { mentionHandle: handle } : {}),
// A personal pod (agent-room, agent-dm, agent-admin) auto-routes every
// plain reply to the agent, so the greeting must not tell the person to
// @mention it there. Only a team pod needs the handle.
...(greetsItself && !isPersonalPodType(pod?.type) ? { mentionHandle: handle } : {}),
...(greetsItself ? { hostedAgentUserId: String(agentUser._id) } : {}),
});
} catch (firstContactError: unknown) {
Expand Down
Loading