Skip to content

build(backend): drop dev dependencies from the runtime image #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 4 commits into from
Oct 31, 2026
Merged

build(backend): drop dev dependencies from the runtime image #3035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ae58e5
build(backend): drop dev dependencies from the runtime image
lilyshen0722 Oct 31, 2026
3587711
build(backend): run operator scripts from dist in the runtime image
lilyshen0722 Oct 31, 2026
a8c1d1c
test(backend): pin the migration script to its compiled target
lilyshen0722 Oct 31, 2026
f8b4bba
docs(runbooks): run token-copy scrubs from compiled dist, not ts-node
lilyshen0722 Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions backend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
# Build stage: dev dependencies are needed for tsc and never ship.
FROM node:22 AS build

WORKDIR /app

COPY package*.json ./

# Install all dependencies including dev dependencies
RUN npm install --include=dev

COPY . .

# Compile TypeScript to dist/
RUN npm run build

# Copy non-JS assets that tsc doesn't copy
RUN cp -r external dist/external 2>/dev/null || true

# Runtime stage
FROM node:22

WORKDIR /app
Expand Down Expand Up @@ -54,16 +73,14 @@ ENV OPENUI_TELEMETRY_DISABLED=1

COPY package*.json ./

# Install all dependencies including dev dependencies
RUN npm install --include=dev
# Production dependencies only. Dev tooling (jest, eslint, ts-node, typescript,
# mongodb-memory-server, ...) stays in the build stage and never reaches prod.
RUN npm ci --omit=dev
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved

COPY . .

# Compile TypeScript to dist/
RUN npm run build

# Copy non-JS assets that tsc doesn't copy
RUN cp -r external dist/external 2>/dev/null || true
# Compiled output from the build stage: dist/ with config/ and external/ in place
COPY --from=build /app/dist ./dist

EXPOSE 5000

Expand Down
2 changes: 1 addition & 1 deletion backend/__tests__/unit/scripts/migrate-github-issue-write-capability.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('migrateGitHubIssueWriteCapability', () => {

test('exposes the migration through the backend package scripts for deploy operators', () => {
expect(backendPackage.scripts['migrate:github-issue-write-capability'])
.toContain('migrate-github-issue-write-capability.ts');
.toBe('node dist/scripts/migrate-github-issue-write-capability.js');
});

test('grants every legacy install for a configured dev identity once, while leaving other identities ungranted', async () => {
Expand Down
6 changes: 3 additions & 3 deletions backend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 15 additions & 14 deletions backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"start": "node dist/server.js",
"dev": "nodemon --exec 'ts-node --transpile-only' server.ts",
"migrate-files": "node migrations/migrateFilesToDB.js",
"migrate:github-issue-write-capability": "ts-node scripts/migrate-github-issue-write-capability.ts",
"migrate:github-issue-write-capability": "node dist/scripts/migrate-github-issue-write-capability.js",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
"test": "jest",
"test:temp-cleanup": "node scripts/verify-jest-temp-cleanup.js",
"test:watch": "jest --watch",
Expand All @@ -23,19 +23,19 @@
"discord:register": "node scripts/register-discord-commands.js",
"discord:list": "node scripts/register-discord-commands.js list",
"bootstrap:clawd-bot": "node scripts/bootstrap-clawd-bot.js",
"backfill:attention-items": "ts-node scripts/backfill-attention-items.ts",
"backfill:message-author-kind": "ts-node scripts/backfill-message-author-kind.ts",
"backfill:local-messages": "ts-node scripts/backfill-local-messages-to-pg.ts",
"migrate:task-priority": "ts-node scripts/migrate-task-priority.ts",
"migrate:task-source-ref-identity": "ts-node scripts/migrate-task-source-ref-identity.ts",
"sweep:resolved-mention-attention": "ts-node scripts/sweep-resolved-mention-attention.ts",
"audit:replied-attention-stamps": "ts-node scripts/audit-replied-attention-stamps.ts",
"sweep:done-task-handoffs": "ts-node scripts/sweep-done-task-handoffs.ts",
"sweep:leftover-runtime-tokens": "ts-node scripts/sweep-leftover-runtime-tokens.ts",
"sweep:stale-digest": "ts-node scripts/sweep-stale-digest.ts",
"backfill:hosted-mcp-client-id": "ts-node scripts/backfill-hosted-mcp-client-id.ts",
"revive:native-installations": "ts-node scripts/revive-native-installations.ts",
"set:agent-descriptions": "ts-node scripts/set-agent-descriptions.ts",
"backfill:attention-items": "node dist/scripts/backfill-attention-items.js",
"backfill:message-author-kind": "node dist/scripts/backfill-message-author-kind.js",
"backfill:local-messages": "node dist/scripts/backfill-local-messages-to-pg.js",
"migrate:task-priority": "node dist/scripts/migrate-task-priority.js",
"migrate:task-source-ref-identity": "node dist/scripts/migrate-task-source-ref-identity.js",
"sweep:resolved-mention-attention": "node dist/scripts/sweep-resolved-mention-attention.js",
"audit:replied-attention-stamps": "node dist/scripts/audit-replied-attention-stamps.js",
"sweep:done-task-handoffs": "node dist/scripts/sweep-done-task-handoffs.js",
"sweep:leftover-runtime-tokens": "node dist/scripts/sweep-leftover-runtime-tokens.js",
"sweep:stale-digest": "node dist/scripts/sweep-stale-digest.js",
"backfill:hosted-mcp-client-id": "node dist/scripts/backfill-hosted-mcp-client-id.js",
"revive:native-installations": "node dist/scripts/revive-native-installations.js",
"set:agent-descriptions": "node dist/scripts/set-agent-descriptions.js",
"sync:seats-record": "node scripts/sync-seats-record.js",
"tsc:check": "tsc --noEmit -p tsconfig.typescheck.json",
"tsc:check:all": "tsc --noEmit"
Expand All @@ -61,6 +61,7 @@
"express-async-errors": "3.1.1",
"express-rate-limit": "^8.3.2",
"helmet": "^7.1.0",
"json5": "^2.2.3",
"jsonwebtoken": "^9.0.0",
"mongodb": "^6.3.0",
"mongoose": "^7.0.3",
Expand Down
6 changes: 3 additions & 3 deletions docs/runbooks/migrate-chat-token-copies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ key ring (`CONNECTOR_SECRET_KEYS`, `CONNECTOR_SECRET_ACTIVE_KEY`) supplied by th
existing ops-runner secret environment (never paste them into a command):

```sh
npx ts-node scripts/migrate-chat-token-copies.ts
node dist/scripts/migrate-chat-token-copies.js
# Review the DRY-RUN counts by type, then explicitly apply:
npx ts-node scripts/migrate-chat-token-copies.ts --apply
npx ts-node scripts/migrate-chat-token-copies.ts
node dist/scripts/migrate-chat-token-copies.js --apply
node dist/scripts/migrate-chat-token-copies.js
```

**What the counts mean.** The final dry run should report zero candidates and
Expand Down
6 changes: 3 additions & 3 deletions docs/runbooks/scrub-feed-token-copies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ From the deployed backend directory, with `MONGO_URI` supplied by the existing
ops-runner secret environment (never paste it into a command):

```sh
npx ts-node scripts/scrub-feed-token-copies.ts
node dist/scripts/scrub-feed-token-copies.js
# Review DRY-RUN counts by type, then explicitly apply:
npx ts-node scripts/scrub-feed-token-copies.ts --apply
npx ts-node scripts/scrub-feed-token-copies.ts
node dist/scripts/scrub-feed-token-copies.js --apply
node dist/scripts/scrub-feed-token-copies.js
```

The final dry run should report zero candidates for both types. Reports contain
Expand Down
Loading