Skip to content

feat(v2): 390 memory layout and section update time (TASK-690 slice 2) - #3131

Closed
lilyshen0722 wants to merge 1 commit into
lark/task-690-agent-memory-tabfrom
lark/task-690-slice2-mobile-section-time
Closed

lilyshen0722 wants to merge 1 commit into
lark/task-690-agent-memory-tabfrom
lark/task-690-slice2-mobile-section-time

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Slice 2 of TASK-690: the 390 memory layout and the section update time. Stacked on #3085 (slice 1, 1440 layout), so the diff here is slice 2 only.

What changed

  • The memory index returns updatedAt per section (backend/routes/agentMemoryView.ts). It is null for daily and cycles, which have no section time, and for a stored value that does not parse. No note gets a time.
  • Each group shows one line: "Section updated ", from the newest section in that group. It is the section's last update, not a note's time.
  • At 390: search sits above the three groups, the group list is hidden, and each group collapses (<details>, open by default). At 1440 the groups stay open and the chevron is hidden.

Per the CTO ruling (11-01): no tags, and no writer or schema change. Tags are a separate Tier 2 decision under D211.

Tests

  • Backend: agent-memory-editor.test.js 9/9, including the section time on the index and null for a missing time.
  • Frontend: V2AgentMemory.test.tsx plus the i18n suites, 43/43. The group time shows once per group and never on a note.

Screenshots (local dev build, mocked owner index, .playwright-mcp dir, gitignored)

  • 390 light and dark. The fixture has no updatedAt, so the group time line is not in these shots. The test covers it.

Gaps against the frame, named here

  • No active state on the group nav.
  • The frame's bottom tab bar is the shell's own mobile bar, which is what renders.
  • The top tab row is the existing app tab style, not the frame's segmented control.
  • Hover actions (pin, edit, more) are not built.

Measurements: measure_after.js artboard mode regenerates targets from the frame only. Prod numbers come after deploy.

Written by Lark, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

The memory index returns updatedAt per section. The group shows it once,
labelled as the section's last update. Notes carry no time. Tags are not
drawn: the writer records none, and that is a separate Tier 2 decision.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: lark <WyJsYXJrIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/default
@samxu01
samxu01 force-pushed the lark/task-690-agent-memory-tab branch from ae56cfa to 7a479bc Compare November 1, 2026 01:51
@samxu01
samxu01 force-pushed the lark/task-690-slice2-mobile-section-time branch from e81126c to 5d3073c Compare November 1, 2026 01:51
@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Slice 2 at 5d3073c, restacked on slice 1 at 7a479bc. Every check passes except PR targets main, which is structural: this PR is stacked on the slice 1 branch. I'll retarget it to main once #3085 merges. The 390 layout and the section updatedAt line are as agreed (A, closed by Lily at 01:50Z): one Section updated line per group, no per-note time, no tags, no writer change.

Written by Lark, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS at 5d3073c on the code. The base retarget is the only open item and waits on #3085. @lily-shen

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Superseded by #3136 (TASK-732), which carries this behaviour onto the D223 rebuild of the memory surface. Closing without merging, per Lark.

samxu01 pushed a commit that referenced this pull request Nov 1, 2026
…urnal (TASK-732)

Carries the slice 1 and slice 2 memory work (#3085, #3131) onto main
without the old-structure drafts. Adds the owner Memory route, the group
split (Rules, How I work, Journal), the search, the section update line
per group, the collapsible 390 layout, and the additive section updatedAt
on the owner memory index. The frame restyle and the staging screenshot
diff are not in this commit yet.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: lark <WyJsYXJrIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant