Skip to content

fix(v2): memory page spans the pane at the frame's width (TASK-732) #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 1 commit into from
Nov 1, 2026
Merged

fix(v2): memory page spans the pane at the frame's width (TASK-732) #3163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/src/v2/__tests__/v2-layout-invariants.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5098,6 +5098,12 @@ describe('agent Memory tab (TASK-690 slice 1 and 2)', () => {
expect(ruleBody(css, '.v2-agent-memory')).toContain('display: grid');
expect(ruleBody(css, '.v2-agent-memory', { within: desktop })).toContain('grid-template-columns: 200px minmax(0, 1fr)');
});
test('the page spans the pane instead of a centred column', () => {
const page = ruleBody(css, '.v2-agent-memory-page');
expect(page).toContain('width: 100%');
expect(page).toContain('max-width: none');
expect(page).toContain('align-self: stretch');
});
test('phone hides the group nav and makes the groups collapsible', () => {
expect(ruleBody(css, '.v2-agent-memory__nav ul', { within: phone })).toContain('display: none');
expect(ruleBody(css, '.v2-agent-memory__gtitle', { within: phone })).toContain('cursor: pointer');
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/v2/agents/V2AgentMemory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ const V2AgentMemory: React.FC = () => {
const settingsHref = `/v2/agents/${encodeURIComponent(agentName)}/${encodeURIComponent(instanceId)}`;

return (
<main className="v2-agent-settings">
<main className="v2-agent-settings v2-agent-memory-page">
<header className="v2-agent-memory__head">
<V2Avatar name={head?.displayName || agentName} src={head?.profilePicture} size="lg" kind="agent" seed={`${agentName}:${instanceId}`} />
<div className="v2-agent-memory__ident">
Expand All @@ -160,6 +160,7 @@ const V2AgentMemory: React.FC = () => {
<Link to={settingsHref}>{t('agentSettings.settings')}</Link>
</nav>
</header>
<div className="v2-agent-memory-page__body">
{state === 'ready' && index ? null : <MemoryShell loading={state === 'loading'} message={state === 'denied' ? t('agentProfile.memory.none', { defaultValue: 'No memory recorded yet.' }) : ''} loadingLabel={t('common.loading', { defaultValue: 'Loading…' })} query={query} setQuery={setQuery} searchLabel={t('agentProfile.memory.search', { defaultValue: 'Search memory' })} navLabel={t('agentSettings.memory', { defaultValue: 'Memory' })} />}
{state === 'ready' && index && (() => {
const needle = query.trim().toLowerCase();
Expand Down Expand Up @@ -243,6 +244,7 @@ const V2AgentMemory: React.FC = () => {
</div>
);
})()}
</div>
</main>
);
};
Expand Down
10 changes: 10 additions & 0 deletions frontend/src/v2/agents/v2-agent-settings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,13 @@
.v2-agent-memory__ident p { margin: 2px 0 0; font-size: 12.5px; color: var(--v2-text-tertiary); }
.v2-agent-memory__seg { margin-left: auto; margin-bottom: 0; }
.v2-agent-memory__navitem { display: flex; align-items: center; gap: 9px; height: 34px; padding: 0 10px; font-size: 13.5px; color: var(--v2-text-tertiary); }

/* Frame width: the agent bar spans the pane, the body fills it (nav left, sections across). */
.v2-agent-memory-page { width: 100%; max-width: none; align-self: stretch; box-sizing: border-box; }
.v2-agent-memory-page .v2-agent-memory__head { margin: 0; padding: 12px 28px; min-height: 76px; border-bottom: 1px solid var(--v2-border-soft); box-sizing: border-box; }
.v2-agent-memory-page .v2-agent-memory__seg { margin-top: 0; border-bottom: 0; }
.v2-agent-memory-page__body { width: 100%; padding: 20px 28px; box-sizing: border-box; }
@media (max-width: 767px) {
.v2-agent-memory-page .v2-agent-memory__head { padding: 12px 16px; }
.v2-agent-memory-page__body { padding: 16px; }
}
Loading