Skip to content

feat(v2): agent settings and memory get the 52px phone top bar (TASK-730) #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 3 commits into from
Nov 1, 2026
Merged

feat(v2): agent settings and memory get the 52px phone top bar (TASK-730) #3167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed8766d
feat(v2): agent settings and memory pages get the 52px phone top bar …
lilyshen0722 Nov 1, 2026
bda6c2e
fix(v2): memory phone bar shrinks its name and stays 52px (TASK-730)
lilyshen0722 Nov 1, 2026
5ef336d
Merge origin/main into task-730-agent-bar
lilyshen0722 Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions frontend/src/v2/__tests__/v2-phone-shell.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,21 @@ describe('D223 phone shell', () => {
expect(css.indexOf('.v2-feature__body {')).toBeLessThan(at);
});

test('agent settings and memory pages get the same 52px bar inside the 760px query', () => {
const agentCss = fs.readFileSync(path.join(__dirname, '../agents/v2-agent-settings.css'), 'utf8');
const tail = agentCss.slice(agentCss.indexOf('D223 (TASK-730)'));
expect(tail).toMatch(/\.v2-agent-settings > \.v2-page-head,\s*\.v2-agent-settings > \.v2-agent-memory__head\s*\{[^}]*min-height:\s*52px/);
const at = agentCss.indexOf('D223 (TASK-730)');
expect(agentCss.slice(0, at).lastIndexOf('@media')).toBe(agentCss.lastIndexOf('@media (max-width: 760px)', at));
});

test('the memory bar lets the name shrink and drops the tab nav margin so it stays 52px', () => {
const agentCss = fs.readFileSync(path.join(__dirname, '../agents/v2-agent-settings.css'), 'utf8');
const tail = agentCss.slice(agentCss.indexOf('D223 (TASK-730)'));
expect(tail).toMatch(/__ident\s*\{\s*min-width:\s*0/);
expect(tail).toMatch(/__seg\s*\{[^}]*margin-top:\s*0/);
});

test('the settings head spans the pane and only the body scrolls', () => {
expect(phone).toMatch(/\.v2-feature--settings > \.v2-feature__body\s*\{[^}]*padding:\s*0/);
expect(phone).toMatch(/\.v2-feature--settings \.v2-feature__legacy\s*\{[^}]*max-width:\s*none/);
Expand Down
15 changes: 15 additions & 0 deletions frontend/src/v2/agents/v2-agent-settings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,21 @@
.v2-agent-settings { padding: 16px; }
.v2-agent-settings__section-head { flex-direction: column; align-items: flex-start; }
.v2-agent-settings__key-meta { display: grid; gap: 4px; }
/* D223 (TASK-730): the same 52px phone top bar feature pages get from
.v2-feature__header. The page pads 16px, so the bar bleeds out of it. */
.v2-agent-settings > .v2-page-head,
.v2-agent-settings > .v2-agent-memory__head {
display: flex; align-items: center; flex-wrap: nowrap; gap: 8px; min-height: 52px;
margin: -16px -16px 12px; padding: 0 10px 0 12px;
border-bottom: 1px solid var(--v2-border-soft);
}
.v2-agent-settings > .v2-page-head h1,
.v2-agent-settings > .v2-agent-memory__head .v2-agent-memory__ident { min-width: 0; }
.v2-agent-settings > .v2-agent-memory__head .v2-agent-memory__seg { flex: none; margin-top: 0; }
.v2-agent-settings > .v2-agent-memory__head .v2-agent-memory__ident h1 {
margin: 0; font: 800 21px/1 var(--v2-font-display); letter-spacing: -0.03em;
white-space: nowrap; overflow: hidden; text-overflow: ellipsis;
}
}

/* Agent memory tab (TASK-690 slice 1): frame metrics from docs/design/artboards/d215
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/v2/v2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10879,6 +10879,8 @@ details[open] > .v2-settings__summary > .v2-settings__icon:last-child { transfor
.v2-root:lang(zh) .v2-login__title,
.v2-root:lang(zh) .v2-feature__title,
.v2-root:lang(zh) .v2-feature__header .v2-feature__title,
.v2-root:lang(zh) .v2-agent-settings > .v2-page-head h1,
.v2-root:lang(zh) .v2-agent-settings > .v2-agent-memory__head .v2-agent-memory__ident h1,
.v2-root:lang(zh) .v2-settings__label,
.v2-root:lang(zh) .v2-settings__account-name,
.v2-root:lang(zh) .v2-settings__section .v2-billing__title,
Expand Down
Loading