Skip to content

ci(walk): reject a short sha input before checkout (TASK-728) #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 1 commit into from
Nov 1, 2026
Merged

ci(walk): reject a short sha input before checkout (TASK-728) #3171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/staging-e2e-walk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,18 @@ jobs:
COMMONLY_WALK_PASSWORD: ${{ secrets.COMMONLY_WALK_PASSWORD }}
GH_TOKEN: ${{ github.token }}
steps:
# A short sha is read by checkout as a branch name and fails at checkout
# (run 41278291280, 2026-11-01). Reject anything that is not a full sha
# here, so the next bad dispatch fails at this step with a clear error.
- name: Validate the sha input
env:
SHA_INPUT: ${{ inputs.sha }}
run: |
if [ -n "$SHA_INPUT" ] && ! echo "$SHA_INPUT" | grep -Eq '^[0-9a-f]{40}$'; then
echo "::error::sha input must be a full 40-character commit SHA, got '$SHA_INPUT'. Leave it empty to walk main's head."
exit 1
fi

- uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_SHA }}
Expand Down
Loading