[lilyshen0722]

Written by Dart, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

What

TASK-752 (P1, connectors, D226 #1). A revoked grant whose catalogue entry is gone (the Atlassian walk leftover) rendered as an "Unknown connector" row in the Tools list, next to the live one. Orphan grants now leave the list once dead. The Connectors trail keeps the record.

Proof

• Regression test TASK-752: a revoked grant whose catalogue entry is gone is not listed in Tools fails on main (2 rows, the second --dead) and passes with the fix.
• ConnectorsPage suites: 193 pass. v2-layout-invariants: 293 pass. ESLint: 0 errors.
• Not rendered at 390 and 1440: no signed-in browser on this seat. The done-test's visual check is owed post-deploy (CTO walk).

Review: own subagent review, then CodeRabbit and CI, then PRESS-READY to @connector-ops with the full head SHA.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Team-Commonly/commonly
• Branch: task-752-revoked-grant
• File: .coderabbit.yaml
• Commit: b814789
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: ed780693-e326-4a8a-8546-b0438a417325

Commits

Reviewing files that changed from the base of the PR and between bbaaa39 and b814789.

Files selected for processing: 2

• frontend/src/v2/__tests__/ConnectorsPage.tools.test.tsx
• frontend/src/v2/connectors/ConnectorsPage.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

The Tools page now excludes dead grants that have no catalogue entry. A test covers an empty catalogue with one live grant and one revoked grant.

Changes: Orphan grant filtering

Layer / File(s)	Summary
Filter orphan grants frontend/src/v2/connectors/ConnectorsPage.tsx, frontend/src/v2/__tests__/ConnectorsPage.tools.test.tsx	The orphan-grant filter excludes grants for which isDead(grant, m.now) is true. The test checks that an empty catalogue with one live and one revoked grant produces exactly one Tools row, which is not marked dead.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

• Team-Commonly/commonly#3143: Introduced the ConnectorsPage and useToolConnectors implementation that this change updates.
• Team-Commonly/commonly#3135: Changes revocation handling; this change uses the revoked state when filtering orphan grants.
• Team-Commonly/commonly#2486: Defines inactive Tools behavior for revoked and expired grants, related to this change’s handling of revoked orphan grants.

Merge Risk: Minimal · up to b8147

The orphan grant is excluded from Tools while remaining available in the Connectors trail; no merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the change: revoked orphan grants (grants whose catalogue entry is missing) are kept out of the Tools list. The raw summary confirms the ConnectorsPage orphanGrants filter now excludes…
Description check		The description states the problem: a revoked grant with no catalogue entry showed as an 'Unknown connector' row in the Tools list. It states the fix: orphan grants leave the list once dead, while the…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the change: revoked orphan grants (grants whose catalogue entry is missing) are kept out of the Tools list. The raw summary confirms the ConnectorsPage orphanGrants filter now excludes dead grants, and the added test covers this case. The title is specific and matches the changeset. It uses the conventional fix(connectors) prefix and includes the TASK-752 reference.

Full details: Description check

Explanation

The description states the problem: a revoked grant with no catalogue entry showed as an 'Unknown connector' row in the Tools list. It states the fix: orphan grants leave the list once dead, while the Connectors trail keeps the record. It also lists the regression test and test results. This matches the ConnectorsPage change and the new TASK-752 test in the summary.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[lilyshen0722]

HEAD: b814789 — GATE: PASS

The one review round (D218, Tier 1 connector UI), by connector-ops at the press. The PR body states a review plan but no verdict was filed as a review, so this is that round.

• ConnectorsPage.tsx: orphanGrants now also requires !isDead(grant, m.now), so a grant that no catalogue entry covers is listed only while it is live access. A live orphan still lists and can still be revoked, which the existing "keeps a live grant listed…" test pins. The render's now is used, matching the rule in toolModel.isDead for render decisions.
• Test: with no catalogue entries and one live plus one revoked grant, exactly one row is listed and it isn't dead. On main both would be listed, so this test fails there.
• It composes with #3194 (TASK-753), which names a live orphan by its server-read connector. The files don't overlap.
• CI is green at this head, and there are no CodeRabbit threads.

GATE: PASS