Skip to content

design(d215): /v2/artifacts frames at 1440 and 390 (TASK-757) - #3219

Closed
lilyshen0722 wants to merge 1 commit into
ux/task-757-runtracefrom
ux/task-757-artifacts
Closed

lilyshen0722 wants to merge 1 commit into
ux/task-757-runtracefrom
ux/task-757-artifacts

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

TASK-757 item 12: draws /v2/artifacts into the d215 artboard at 1440 and 390, light and dark.

Stacked on #3217 (→ #3216 → #3215 → #3214 → #3209). Retarget to main as those merge.

States (3 surfaces, 50 → 56 targets): shared files newest first, nothing shared yet, load failed. "Nothing matches" is the empty box with the filtered line, covered in the state table.

Design calls

  • Rail's Artifacts item is on. At 390 the bar has no Artifacts tab, so Pods is on, as on Run trace.
  • Kind, pod and search share one control row. At 390 they stack and each is 44px.
  • The extension chip is the file icon; chips share one width (44px, the live min is 34px) so names align across PDF, PNG, HTML and DOCX.
  • Nothing is ink: the page has no primary act. 17 more is an ink underlined text key (live is cobalt text; cobalt stays on marks and count chips).
  • At 390 Pod, Shared by and Size drop and the pod folds under the name, as live.

Flags for the builder (non-blocking)

  • The table is capped at 1040px and centered; live is full width, which strands the columns at 1440.
  • Load-failed adds a Retry key; live is a bare line, same as Activity and Profile.

Measured (node cap/measure_after.js, targets.json regenerated, node --test cap/measure_after.test.js 10/10): helper words 61 / 24, scroll 1.0× at both sizes. No contrast exceptions; rows are 40px at 1440 and 44px at 390.

🤖 Generated with Claude Code

… failed at 1440 and 390 (TASK-757)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: ux-lead <WyJ1eC1sZWFkIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-opus-5-5/high

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: PASS @ 117f7e6 — three artifacts frames render at 1440 and 390 in light and dark; copy matches the live page

Rendered all 12 frame/theme combinations and read them against V2ArtifactsPage.tsx and the live v2-artifacts__* CSS.

  • Copy lifted from en.json artifacts.*: title, meta, kinds, columns, "Nothing shared yet. Attach a file in any pod and it lands here.", "Could not load artifacts.", "{n} of {total} · newest first".
  • Fit: every frame scrolls 1.0×. targets.json has 56 rows; node --test cap/measure_after.test.js 10/10.
  • Identity bar: no ink key, 16px rail mark, ext chips as the file icon, cobalt only on the rail badge, rows 40px at 1440 and 44px at 390, no shadows, "pod" never "room". Contrast and 44px exceptions: none.
  • Deliberate departures, flagged in the PR: 1040px table cap, shared chip width, ink 17 more, Retry on the error line.

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Closing: replaced by #3345, which carries the approved Artifacts frames (busy and day zero, 1440 and 390), built in #3376. The branch is kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant