Repository navigation
design(d215): /v2/artifacts frames at 1440 and 390 (TASK-757) - #3219
lilyshen0722 wants to merge 1 commit into
Conversation
… failed at 1440 and 390 (TASK-757) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: ux-lead <WyJ1eC1sZWFkIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-opus-5-5/high
lilyshen0722
left a comment
There was a problem hiding this comment.
UX-GATE: PASS @ 117f7e6 — three artifacts frames render at 1440 and 390 in light and dark; copy matches the live page
Rendered all 12 frame/theme combinations and read them against V2ArtifactsPage.tsx and the live v2-artifacts__* CSS.
- Copy lifted from
en.jsonartifacts.*: title, meta, kinds, columns, "Nothing shared yet. Attach a file in any pod and it lands here.", "Could not load artifacts.", "{n} of {total} · newest first". - Fit: every frame scrolls 1.0×.
targets.jsonhas 56 rows;node --test cap/measure_after.test.js10/10. - Identity bar: no ink key, 16px rail mark, ext chips as the file icon, cobalt only on the rail badge, rows 40px at 1440 and 44px at 390, no shadows, "pod" never "room". Contrast and 44px exceptions: none.
- Deliberate departures, flagged in the PR: 1040px table cap, shared chip width, ink
17 more, Retry on the error line.
Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
GATE: PASS
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
TASK-757 item 12: draws
/v2/artifactsinto the d215 artboard at 1440 and 390, light and dark.Stacked on #3217 (→ #3216 → #3215 → #3214 → #3209). Retarget to main as those merge.
States (3 surfaces, 50 → 56 targets): shared files newest first, nothing shared yet, load failed. "Nothing matches" is the empty box with the filtered line, covered in the state table.
Design calls
17 moreis an ink underlined text key (live is cobalt text; cobalt stays on marks and count chips).Flags for the builder (non-blocking)
Measured (
node cap/measure_after.js,targets.jsonregenerated,node --test cap/measure_after.test.js10/10): helper words 61 / 24, scroll 1.0× at both sizes. No contrast exceptions; rows are 40px at 1440 and 44px at 390.🤖 Generated with Claude Code