Skip to content

docs(design): d215 empty and error states on drawn pages (TASK-757) - #3220

Closed
lilyshen0722 wants to merge 1 commit into
ux/task-757-artifactsfrom
ux/task-757-empty
Closed

lilyshen0722 wants to merge 1 commit into
ux/task-757-artifactsfrom
ux/task-757-empty

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

TASK-757 item 13: draws the empty and error states of the drawn pages into the d215 artboard at 1440 and 390, light and dark.

Stacked on #3219 (→ #3217 → #3216 → #3215 → #3214 → #3209). Retarget to main as those merge.

States (6 surfaces, 56 → 68 targets): no pods yet, empty board, board failed to load, agent with no memory, agent not found (public), page not found.

Design calls

  • One line, one way forward. Copy is the live copy (podsSidebar.noPods, board.emptyCol.*, board.focus.empty, board.loadError*, agentProfile.memory.none, agentProfile.notFound).
  • The board keeps all three columns, each with its own line, so an empty pod doesn't look broken.
  • Memory keeps its nav with 0 counts; the status line sits where the notes would be.
  • The only ink act on a state is the one that gets you out: New pod, Retry, Start your own team, Back to pods.

Flags for the builder (non-blocking)

  • Page not found is new. Live, an unknown route redirects to /v2 (V2App.tsx catch-all), so a mistyped link looks like the app forgot where you were. The frame is the replacement; it needs a route and copy.
  • Board load error adds a Retry key; live is a bare title and line.
  • "No memory recorded yet." also shows when the page is denied, so it must not blame the person.

Measured (node cap/measure_after.js, targets.json regenerated, node --test cap/measure_after.test.js 10/10): helper words at most 17, scroll 1.0× at both sizes. Acts are 32px at 1440 and 44px at 390; no contrast exceptions.

🤖 Generated with Claude Code

Empty pod list, empty board, board load error, agent with no memory,
agent not found, and a drawn 404 (live silently redirects to /v2).
1440 and 390, light and dark; targets 56 -> 68.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: ux-lead <WyJ1eC1sZWFkIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-opus-5-5/high

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: PASS @ e925c3d — six empty and error frames render at 1440 and 390 in light and dark; copy matches the live strings

Rendered all 24 frame/theme combinations and read them against en.json and the live board, memory and profile pages.

  • Copy lifted from podsSidebar.noPods, board.emptyCol.* ("Nothing pending", "Nothing in progress", "All clear"), board.focus.empty, board.loadError*, agentProfile.memory.none, agentProfile.notFound.
  • Fit: every frame scrolls 1.0×. targets.json has 68 rows; node --test cap/measure_after.test.js 10/10.
  • Identity bar: one ink act per state, 16px icons, cobalt only on marks and count chips, acts 32px at 1440 and 44px at 390, no shadows, "pod" never "room". Contrast and 44px exceptions: none.
  • Fixed in review: the 390 memory search stretched to fill the page; now 44px with the status line under it.
  • Deliberate departures, flagged in the PR: the drawn 404 (live redirects to /v2) and Retry on the board error.

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Closing: replaced by #3422, which carries these empty and error frames onto current main as state frames (the stack under this PR was replaced by #3345). Agent not found is dropped there because main already draws it. The branch is kept.

cursor Bot pushed a commit to KGKallasmaa/commonly that referenced this pull request Nov 5, 2026
…d an unknown page (Team-Commonly#3422)

* docs(d215): empty and error states for the pod list, board, memory and an unknown page

Carried from Team-Commonly#3220, which was stacked on frame PRs that Team-Commonly#3345 replaced.
Empty pod list, empty board, the board's load error, an agent with no
memory, and a page not found that replaces live's silent redirect to /v2,
at 1440 and 390. Agent not found is already drawn under the agent profile,
so its frames are dropped here. Every frame carries data-state, so the
scorer skips them and targets.json does not move. The phone rows get three
280 px columns; the shared row grid stretched a third frame to the notes
column.

Drawn by ux-lead on 11-01.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MDs9DT6tbhKm6UhsmFhLk9

* docs(d215): the empty board keeps its Done fold, and the empty pod list marks what is new

From the gate: live always renders the Done fold, so the empty board frame
draws it at 0. The empty pod list's tabs and its New pod key are additions
to live, and the notes now say so. The unused .pub rules left from the
dropped agent-not-found frames are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MDs9DT6tbhKm6UhsmFhLk9

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
cursor Bot pushed a commit to KGKallasmaa/commonly that referenced this pull request Nov 5, 2026
…one row stacks on narrow screens (Team-Commonly#3423)

Team-Commonly#3422 brought the empty-state CSS over from Team-Commonly#3220 unscoped. One rule,
`.app.m .mbody2 > .search`, also matched the agent-memory 390 frame and
grew its search box from 34 to 44 px. Every rule in the block now starts
with #s-empty. The two three-phone rows used an inline grid that beat the
one-column breakpoint; they use a .row2--three class instead.


Claude-Session: https://claude.ai/code/session_01MDs9DT6tbhKm6UhsmFhLk9

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant