Repository navigation
docs(design): d215 empty and error states on drawn pages (TASK-757) - #3220
lilyshen0722 wants to merge 1 commit into
Conversation
Empty pod list, empty board, board load error, agent with no memory, agent not found, and a drawn 404 (live silently redirects to /v2). 1440 and 390, light and dark; targets 56 -> 68. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: ux-lead <WyJ1eC1sZWFkIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-opus-5-5/high
lilyshen0722
left a comment
There was a problem hiding this comment.
UX-GATE: PASS @ e925c3d — six empty and error frames render at 1440 and 390 in light and dark; copy matches the live strings
Rendered all 24 frame/theme combinations and read them against en.json and the live board, memory and profile pages.
- Copy lifted from
podsSidebar.noPods,board.emptyCol.*("Nothing pending", "Nothing in progress", "All clear"),board.focus.empty,board.loadError*,agentProfile.memory.none,agentProfile.notFound. - Fit: every frame scrolls 1.0×.
targets.jsonhas 68 rows;node --test cap/measure_after.test.js10/10. - Identity bar: one ink act per state, 16px icons, cobalt only on marks and count chips, acts 32px at 1440 and 44px at 390, no shadows, "pod" never "room". Contrast and 44px exceptions: none.
- Fixed in review: the 390 memory search stretched to fill the page; now 44px with the status line under it.
- Deliberate departures, flagged in the PR: the drawn 404 (live redirects to /v2) and Retry on the board error.
Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
GATE: PASS
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
…d an unknown page (Team-Commonly#3422) * docs(d215): empty and error states for the pod list, board, memory and an unknown page Carried from Team-Commonly#3220, which was stacked on frame PRs that Team-Commonly#3345 replaced. Empty pod list, empty board, the board's load error, an agent with no memory, and a page not found that replaces live's silent redirect to /v2, at 1440 and 390. Agent not found is already drawn under the agent profile, so its frames are dropped here. Every frame carries data-state, so the scorer skips them and targets.json does not move. The phone rows get three 280 px columns; the shared row grid stretched a third frame to the notes column. Drawn by ux-lead on 11-01. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MDs9DT6tbhKm6UhsmFhLk9 * docs(d215): the empty board keeps its Done fold, and the empty pod list marks what is new From the gate: live always renders the Done fold, so the empty board frame draws it at 0. The empty pod list's tabs and its New pod key are additions to live, and the notes now say so. The unused .pub rules left from the dropped agent-not-found frames are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MDs9DT6tbhKm6UhsmFhLk9 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…one row stacks on narrow screens (Team-Commonly#3423) Team-Commonly#3422 brought the empty-state CSS over from Team-Commonly#3220 unscoped. One rule, `.app.m .mbody2 > .search`, also matched the agent-memory 390 frame and grew its search box from 34 to 44 px. Every rule in the block now starts with #s-empty. The two three-phone rows used an inline grid that beat the one-column breakpoint; they use a .row2--three class instead. Claude-Session: https://claude.ai/code/session_01MDs9DT6tbhKm6UhsmFhLk9 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
TASK-757 item 13: draws the empty and error states of the drawn pages into the d215 artboard at 1440 and 390, light and dark.
Stacked on #3219 (→ #3217 → #3216 → #3215 → #3214 → #3209). Retarget to main as those merge.
States (6 surfaces, 56 → 68 targets): no pods yet, empty board, board failed to load, agent with no memory, agent not found (public), page not found.
Design calls
podsSidebar.noPods,board.emptyCol.*,board.focus.empty,board.loadError*,agentProfile.memory.none,agentProfile.notFound).Flags for the builder (non-blocking)
/v2(V2App.tsxcatch-all), so a mistyped link looks like the app forgot where you were. The frame is the replacement; it needs a route and copy.Measured (
node cap/measure_after.js,targets.jsonregenerated,node --test cap/measure_after.test.js10/10): helper words at most 17, scroll 1.0× at both sizes. Acts are 32px at 1440 and 44px at 390; no contrast exceptions.🤖 Generated with Claude Code