Skip to content

fix(agent-settings): frame review fixes after #3183 (TASK-731) #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 2 commits into from
Nov 1, 2026
+16 −6
Merged

fix(agent-settings): frame review fixes after #3183 (TASK-731) #3239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe35b28
fix(agent-settings): frame column cap, phone fold chrome, header stac…
lilyshen0722 Nov 1, 2026
08796e0
fix(agent-settings): keep phone status line visible under the label (…
lilyshen0722 Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion frontend/src/v2/__tests__/v2-layout-invariants.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,15 @@ describe('v2 layout invariants (CSS rule presence)', () => {
expect(header).toContain('align-items: flex-start');
});

test('agent Settings phone rows keep the value cell visible under the label', () => {
const surface = read('../agents/v2-agent-settings-surface.css');
const phone = surface.slice(surface.indexOf('@media (max-width: 600px)'));
expect(ruleBody(phone, '.v2-agent-settings-page .lrow .vl')).toContain('grid-row: 2');
expect(ruleBody(phone, '.v2-agent-settings-page .lrow .ac')).toContain('grid-row: 1 / span 2');
});

test('agent Settings buttons retain their chrome over the v2 button reset', () => {
const button = ruleBody(agentSettings, '.v2-root .v2-agent-settings button:not(.MuiButtonBase-root):not(.b):not(.seg > button)');
const button = ruleBody(agentSettings, '.v2-root .v2-agent-settings button:not(.MuiButtonBase-root):not(.b):not(.seg > button):not(.v2-agent-wake-pods__fold)');
expect(button).toContain('border: 1px solid var(--v2-border)');
expect(button).toContain('background: var(--v2-surface)');
expect(ruleBody(agentSettings, '.v2-root .v2-agent-settings .v2-agent-settings__section-head button')).toContain('background: var(--v2-ink)');
Expand Down
5 changes: 4 additions & 1 deletion frontend/src/v2/agents/v2-agent-settings-surface.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
.v2-agent-settings-page .ph { flex: none; min-height: 76px; display: flex; align-items: center; gap: 10px; padding: 0 20px 0 28px; border-bottom: 1px solid var(--d); box-sizing: border-box; }
.v2-agent-settings-page .ph h1 { font: 800 24px/1 var(--f-display); letter-spacing: -0.03em; margin: 0; white-space: nowrap; }
.v2-agent-settings-page .ph .sp { flex: 1; }
.v2-agent-settings-page .ahead { display: flex; align-items: center; gap: 12px; }
.v2-agent-settings-page .ahead { display: block; }
.v2-agent-settings-page .ahead h1 { font: 800 24px/1 var(--f-display); letter-spacing: -0.03em; margin: 0; }
.v2-agent-settings-page .ahead .st { display: flex; align-items: center; gap: 6px; font: 500 11.5px/1 var(--f-mono); color: var(--mu); margin-top: 5px; }
.v2-agent-settings-page .mo { font-family: var(--f-mono); }
Expand All @@ -90,6 +90,7 @@
.v2-agent-settings-page .gtitle { font: 500 11.5px/1 var(--f-mono); color: var(--mu); margin: 18px 4px 8px; display: flex; align-items: center; gap: 8px; }
.v2-agent-settings-page .gtitle:first-child { margin-top: 0; }
.v2-agent-settings-page .list { border-radius: 12px; box-shadow: inset 0 0 0 1px var(--d); background: var(--sf); }
.v2-agent-settings-page__col { max-width: 1000px; margin: 0 auto; }
.v2-agent-settings-page .lrow { display: grid; grid-template-columns: 180px minmax(0, 1fr) auto; align-items: center; gap: 14px; min-height: 52px; padding: 8px 14px 8px 16px; border-top: 1px solid var(--d); }
.v2-agent-settings-page .lrow:first-child { border-top: 0; }
.v2-agent-settings-page .lrow .lb { font-size: 13px; font-weight: 600; color: var(--ink); display: flex; align-items: center; gap: 8px; }
Expand Down Expand Up @@ -130,6 +131,8 @@
.v2-agent-settings-page .ph .sp { display: none; }
.v2-agent-settings-page .lrow { grid-template-columns: minmax(0, 1fr) auto; min-height: 48px; padding: 8px 12px; }
.v2-agent-settings-page .lrow .lb { font-weight: 500; }
.v2-agent-settings-page .lrow .vl { grid-column: 1; grid-row: 2; font-size: 12px; }
.v2-agent-settings-page .lrow .ac { grid-row: 1 / span 2; }
}
@media (max-width: 600px) {
.v2-agent-settings-page .wt thead { display: none; }
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/v2/agents/v2-agent-settings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
.v2-agent-settings__section h2 { margin: 0; font-family: var(--v2-font-display); font-size: 20px; }
/* Lifted buttons (.b, icon .ib, segment tabs) belong to the surface (v2-agent-settings-surface.css);
excluded here so this (0,3,1) rule does not out-rank their sizing or focus ring. */
.v2-root .v2-agent-settings button:not(.MuiButtonBase-root):not(.b):not(.seg > button) {
.v2-root .v2-agent-settings button:not(.MuiButtonBase-root):not(.b):not(.seg > button):not(.v2-agent-wake-pods__fold) {
min-height: 34px;
padding: 6px 12px;
border: 1px solid var(--v2-border);
Expand All @@ -55,9 +55,9 @@
font-weight: 600;
cursor: pointer;
}
.v2-root .v2-agent-settings button:not(.b):not(.seg > button):hover { background: var(--v2-surface-hover); }
.v2-root .v2-agent-settings button:not(.b):not(.seg > button):focus-visible { box-shadow: var(--v2-focus-ring); outline: 1px solid var(--v2-accent); }
.v2-root .v2-agent-settings button:not(.b):not(.seg > button):disabled { opacity: .55; cursor: default; }
.v2-root .v2-agent-settings button:not(.b):not(.seg > button):not(.v2-agent-wake-pods__fold):hover { background: var(--v2-surface-hover); }
.v2-root .v2-agent-settings button:not(.b):not(.seg > button):not(.v2-agent-wake-pods__fold):focus-visible { box-shadow: var(--v2-focus-ring); outline: 1px solid var(--v2-accent); }
.v2-root .v2-agent-settings button:not(.b):not(.seg > button):not(.v2-agent-wake-pods__fold):disabled { opacity: .55; cursor: default; }
.v2-root .v2-agent-settings .v2-agent-settings__section-head button { background: var(--v2-ink); color: var(--v2-on-ink); border-color: var(--v2-ink); }
.v2-root .v2-agent-settings .v2-agent-settings__actions button:first-child { background: var(--v2-ink); color: var(--v2-on-ink); border-color: var(--v2-ink); }
.v2-root .v2-agent-settings .v2-agent-settings__section-head button:hover,
Expand Down
Loading