Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/design/artboards/d215/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Passing the prod check means a page matches its frame. It means the page matches

| Group | Frames | Source |
|---|---|---|
| **From Sam's pick** | sidebar, chat, board, agent-memory, agent-settings, settings, connectors | The seven surfaces picked on 10-31 (#3059). Later edits: the theme switch (#3175) and the open thread (#3178). #3288 (the 390 agent-settings and settings frames, brought up to the shipped pages) and #3289 (memory notes drawn as the API holds them) moved those frames toward the live page, so read them with that in mind. |
| **From Sam's pick** | sidebar, chat, board, agent-memory, agent-settings, settings, connectors | The seven surfaces picked on 10-31 (#3059). Later edits: the theme switch (#3175) and the open thread (#3178). #3288 (the 390 agent-settings and settings frames, brought up to the shipped pages) and #3289 (memory notes drawn as the API holds them) moved those frames toward the live page, so read them with that in mind. **Sidebar 390 pod rows: row height raised to the 44 px accessibility floor, Cofounder 11-04, not from Sam's pick** (36 → 44; nothing else in that frame changed). Sam can reverse it. |
| **Drawn after the pick** | dm, byo, byo-handoff, connect, team, firstrun-\*, signin, signup, signup-sent, verify-email, forgot-password, reset-password, cli-authorize, invite, invite-required, profile, agent-profile, run-trace-after, chat-trace, chat-agents-away, and the agent-settings and settings state blocks | New drawings in the picked language, from 11-01 on. Sam has not reviewed them as a set. |
| **Approved by Sam, 11-03** | activity-busy, activity-dayzero (`#s-activity-signal`); artifacts-busy, artifacts-dayzero (`#s-artifacts-signal`); task-record-\*; handoff-\* | Sam saw each one live-beside-proposed and answered "Build as drawn" for all four pages. Activity and Artifacts are built only from the picked surfaces' blocks, and both are scored since their builds. Task record and handoff still carry `data-state`, so the scorer skips them. |

Expand Down
3 changes: 3 additions & 0 deletions docs/design/artboards/d215/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@
.pod.on { background: var(--t); font-weight: 600; color: var(--ink); }
.pod.on .mk { background: var(--c); color: #fff; }
.pod .pin { display: none; }
/* Sidebar 390: row height raised to the 44 px accessibility floor, Cofounder 11-04, not from Sam's pick.
Eight 36 px rows can't each keep a 44 px target. Only the row height changes. */
.frame[data-surface="sidebar"][data-vp="390"] .pod { height: 44px; }
.pod.hov .pin { display: grid; position: absolute; right: 6px; background: var(--t); }
.pod.hov .tm, .pod.hov .un { visibility: hidden; }

Expand Down
6 changes: 3 additions & 3 deletions frontend/src/v2/V2App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ const V2AgentProfileRoute: React.FC = () => {
return (
<V2AgentProfile
shell={isAuthenticated
? (page) => <V2AuthenticatedShell>{feature(t('common.pageTitle.agentProfile'), page, false, false, 'v2-feature--bar v2-feature--aprofile')}</V2AuthenticatedShell>
? (page) => <V2AuthenticatedShell>{feature(t('common.pageTitle.agentProfile'), page, false, false)}</V2AuthenticatedShell>
: undefined}
/>
);
Expand Down Expand Up @@ -386,7 +386,7 @@ const V2App: React.FC = () => {
/>
<Route
path="pods/:podId/runs/:runId"
element={feature(t('runTrace.title'), <V2RunTrace />, false, false, 'v2-feature--bar v2-feature--run-trace')}
element={feature(t('runTrace.title'), <V2RunTrace />, false, false, 'v2-feature--run-trace')}
/>
<Route
path="pods/:podId/tasks/:taskId/record"
Expand All @@ -410,7 +410,7 @@ const V2App: React.FC = () => {
/>
<Route
path="profile/:id"
element={feature(t('common.pageTitle.profile'), <V2PersonProfile />, false, false, 'v2-feature--bar v2-feature--profile')}
element={feature(t('common.pageTitle.profile'), <V2PersonProfile />, false, false, 'v2-feature--profile')}
/>
<Route
path="admin/integrations/global"
Expand Down
8 changes: 6 additions & 2 deletions frontend/src/v2/__tests__/ConnectorsPage.layout.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,12 @@ describe('Connectors page: the tile surface', () => {
await clickTile('GitHub');
const popover = await findPopover('GitHub');
expect(within(popover).getByText('GitHub tool copy.')).toBeInTheDocument();
for (const name of names.slice(0, 3)) expect(within(popover).getByText(name)).toBeInTheDocument();
expect(within(popover).queryByText('d.four')).toBeNull();
// A chip shows the name after its namespace, as the frame draws it; the full name is its title.
for (const name of names.slice(0, 3)) {
expect(within(popover).getByText(name.slice(name.indexOf('.') + 1))).toHaveAttribute('title', name);
}
expect(within(popover).queryByText('four')).toBeNull();
expect(within(popover).queryByText('a.one')).toBeNull();
expect(within(popover).getByText('+2')).toBeInTheDocument();
expect(within(popover).getByRole('button', { name: 'Add' })).toBeInTheDocument();
});
Expand Down
Loading
Loading