Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
handleSelectfocuses the control before changing its options. If a page's focus handler disables the select or its enclosing fieldset, the tool still changes the value, dispatchesinput/changeand reports success.For example, selecting
caon<select onfocus="this.disabled=true">changes an initiallyusvalue even though the focus handler has disabled the control. This is reproduced against real headless Chrome through the production handler, not just a mocked DOM.Fix
Check
:disabledinside the existing page-side mutation function immediately before changing options. Returninvalid_paramswithout changing the value or dispatching events. Native selector semantics cover disabled fieldsets and the first-legend exception. No new RPC error reason or dependency.Initially disabled controls retain Chrome's existing
DOM.focusfailure behavior. Enabled controls still select and dispatch events normally.Validation
BSK_SELECT_CHROMEin an isolated headless browser/profile.--formatter-enabled=falsepasses (646 files). Stylelint and DSH typecheck pass.No existing assertions, timeouts or skip conditions were relaxed. Implemented and tested with Codex assistance; this is not a claim of human review or a fully green repository-wide suite.