Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
bsk extractincludes text and links from subtrees hidden with CSScontent-visibility: hidden. Discovery also returns tables and lists inside those subtrees, and explicit extraction accepts them instead of returningextract_target_hidden.For example, extracting this table currently returns
Visible\nHidden text:Chrome renders only
Visible. The collector already excludes display-none and zero-opacity subtrees, but its cached ancestor check does not handle content visibility.Fix
Add the missing rule to that existing ancestor check. Preserve rendered content on display types where Chromium ignores the property, and keep offscreen
content-visibility: autocontent extractable. No protocol, dependencies or page mutations are added.Verification
d87ca6798b647107a3c7bbf79902397e72e90269with two workers; all 11 real-Chrome extraction tests also passed in a separate opt-in run.The browser suite serializes the production collector into an isolated renderer world; it is not an installed-extension CLI end-to-end run. Other opt-in browser suites and Rust tests were not run. The DSH runtime suite was subsequently checked: 536 passed, 2 failed. An isolated checkout of unchanged base
d9a78aed47874459ae1e44523a597e42dd9acf99, using the same dependencies and two workers, has the same 536 passed, 2 failed result. Both failures are the existing runner kill-grace cases (settles after the kill grace when neither exit nor close ever firesandsettles killAll and killFor children that never report back); this PR does not change the DSH package. This does not claim the fullpnpm lintcommand passed.Implemented and tested with assistance from OpenAI Codex. No independent human review is claimed.