Repository navigation
Re-sync KITT db6e309: one ask rings once, not on every later hand-back - #74
Merged
Merged
Conversation
Brings KITT #279: the needs-you alert remembers the last ask it rang per session, so a session working past an unanswered ask no longer re-rings it on every hand-back; the open-ask line rings nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UMMrrs6msaFav9KMGMkyyd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94b763ece1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
TheAnswerManIsHere
added a commit
that referenced
this pull request
Nov 3, 2026
## What this changes This re-syncs DojoOS with KITT PR #280 — Needs-you alert: key a banner on its own block, so /status does not re-ring an unchanged ask. It closes the gap Codex found on DojoOS PR #74 — Re-sync KITT db6e309: one ask rings once, not on every later hand-back. The needs-you alert now matches a banner only on its own text, ending at the banner's closing rule. Before this, when `/status` reproduced an open ask inside a longer briefing, the alert treated it as a new ask and rang again. Now it rings nothing. Only the alert script and its test change. Oracle source: Tier A, the bugfix oracle in KITT PR #280 — Needs-you alert: key a banner on its own block, so /status does not re-ring an unchanged ask. ## Decisions taken on my recommendation None beyond KITT PR #280 — Needs-you alert: key a banner on its own block, so /status does not re-ring an unchanged ask. Latitude this grants me: none. ## Verification `node --test scripts/__tests__/needs-you-alert.test.mjs`: 25 pass, 0 fail. Post-merge verification: the close-out Repl sync. --- _Generated by [Claude Code](https://claude.ai/code/session_01UMMrrs6msaFav9KMGMkyyd)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This syncs KITT PR #279 — Needs-you alert: one ask rings once, not on every later hand-back — into DojoOS.
The needs-you alert now remembers the last ask it rang in each session. A session that keeps working past an unanswered ask no longer re-rings David's phone on every hand-back, and the
Still waiting on you:line rings nothing. New or changed asks still ring. Nothing else changes.Oracle source: Tier A, the bugfix oracle in KITT PR #279 — Needs-you alert: one ask rings once, not on every later hand-back (David's report of 2026-11-03).
Decisions taken on my recommendation
None beyond KITT PR #279 — Needs-you alert: one ask rings once, not on every later hand-back.
Latitude this grants me: none.
Verification
node --test scripts/__tests__/needs-you-alert.test.mjs: 25 pass, 0 fail.claude-core.mdrule 6, and thepr-watchskill.Post-merge verification: the close-out Repl sync.
Generated by Claude Code