Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
@edwh Could you split this into different PRs please? I prefer to have them more atomic where possible. |
…from group count - The network page no longer calculates stats before rendering; the Vue component fetches them from the API (it already did when initialStats was empty), showing "…" until they arrive. - Network::stats() loads only group ids (no member-count scopes or eager loads), and bulkGroupStats pages events by primary key instead of a growing OFFSET. The "add groups" picker selects only id and name. - stats() returns 'groups', counting only non-archived groups; impact stats still include archived groups' past events. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
edwh
force-pushed
the
network-stats-and-group-country
branch
from
September 23, 2026 15:05
734dbb3 to
0280645
Compare
edwh
changed the title
…iled-load state - bulkGroupStats(): reorder() before lazyById. past() orders by date, and lazyById only strips an existing order on the id column, so pages were ordered by date and paged by id: events beyond the first 200 were skipped or double-counted (399 of 450 in the new test). - statsForTag() returns 'groups' like Network::stats(). - NetworkPage shows '–' if the stats request fails, not '…' forever. - StatsTestCase declares $_ratioPowered (dynamic property deprecation hid test failure messages under process isolation). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #927. The group country fix that was in here has been split out and merged as #916.
Summary
What changes in the API
GET /api/networks/{id}/statsnow includesgroups: the number of non-archived groups in the network. The network page uses this.groups, counted the same way.Code Quality Review
bulkGroupStatspages through events by id instead of by offset, which is what made it slow.Test Plan
groupsfigure.