Faster PHPUnit setUp (fixes CircleCI build timeouts) - #915
Merged
Merged
Conversation
…test TestCase::setUp ran 20 TRUNCATEs and an ALTER TABLE AUTO_INCREMENT on all 68 tables before every test (~5s each under processIsolation), which put PHPUnit at ~45 of the build job's 60 minutes and caused timeouts. Now uses DELETE, only re-randomises auto increments that are still low (just after migrate:fresh), and always resets networks (its ids go in the tinyint users.repair_network). ~4x faster locally. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
2 of 3 tasks
ngm
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up
TestCase::setUp, which runs before every test underprocessIsolation.migrate:fresh, rather than via ALTER TABLE on every table per test.networkscounter is reset every test (1–100), because network ids are stored in the tinyintusers.repair_network.PHPUnit on CI: ~23 min (was ~45). Build job: ~37 min, within CircleCI's 60 min limit.
🤖 Generated with Claude Code