Skip to content

feat(application): identify SDK agents with computed names - #1016

Merged
pengfei-threemoonslab merged 1 commit into
mainfrom
codex/912-source-identity
Oct 10, 2026
Merged

pengfei-threemoonslab merged 1 commit into
mainfrom
codex/912-source-identity

Conversation

@pengfei-threemoonslab

@pengfei-threemoonslab pengfei-threemoonslab commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Computed SDK names no longer hide a uniquely identifiable construction. A returned builder or class-held attribute receives a stable source label when the existing variable/literal rules cannot identify it. Line changes and moves between a class's methods do not change that label; competing constructions are refused rather than joined.

Refs #912. Targets main after #1015 was squash-merged, following the owner-approved implementation order. This is the source-identity increment that can land before #874's instance/template tool flow. Concrete-subclass expansion and full #912 acceptance remain open. The owner deferred corpus, ledger, Q2 and released-build baseline work to separate implementation.

Behavior

  • Qualified source labels are internal provenance, not evaluated runtime names or deployed-binding declarations.
  • Colliding labels, identity-basis renames and edited file moves name correspondence ambiguity. Affected tool and handoff rows are not_established.
  • If a construction becomes an unread factory at the same source site, its bindings remain unestablished rather than becoming additions/removals.
  • Existing list, constructor, handle, mutation and escape proofs remain in force.
  • Documentation states the identity order, collision rules and remaining template-method limits. No public JSON field or schema version was added.

Authorship

  • A coding agent wrote some or all of this change. Agent: Codex.
  • A person read the whole diff before opening this pull request.

Validation

  • New source-identity tests: 17 passed, including computed names, builder returns, class moves, collisions, bidirectional unread factories, handoff target renames and edited file moves.

  • Identity/unobserved regression selection: 121 passed.

  • Application comparison/review/shard compatibility: 85 passed.

  • Related SDK builder and schema selection: 3,140 passed, 120 existing expected-failure cases.

  • Final affected source-identity/review selection: 42 passed.

  • Ruff and diff whitespace checks passed. The new shard weight has measured JUnit provenance; existing full-suite weights are retained.

  • Committed-source verifier/control: complete, release decision passed.

  • Original exact-head GitHub CI: all applicable required checks passed; release-tag-only check skipped.

  • Sequential restack at e2023e3d12a5: original source-identity patch retained alongside fix(application): retain unread SDK tool-list candidates #1010; 30 candidate/source-identity tests passed. Committed control is complete / passed; exact-head GitHub CI passed all 14 applicable checks, including six suite shards and aggregate coverage; the release-tag-only check was skipped.

  • Final six-increment combination at a4ea56e5987bf: 1,546 tests passed, 1 skipped; independent combination review passed 383 tests with no actionable P1/P2. Source remained unchanged during both selections. No corpus or baseline was scored.

Independent review and fixes

  1. Initial read-only review found two P2 defects: an unread factory lost the fallback identity's absence limit; a renamed handoff target was reported as an added/removed handoff. Both now carry explicit uncertainty, with actual Git comparison regressions in both directions.
  2. Follow-up confirmed those fixes, preserved existing gaps and exact relocation handling, and found that a file moved with a comment could still look like a new/deleted capability.
  3. Final review confirmed the qualified-site ambiguity guard for edited moves. It establishes no correspondence and joins no agents. The reviewer independently passed 17 targeted checks across the final two rounds, verified internal-field exclusion, and found no remaining actionable issues.

These reviews did not score a corpus or establish a Q2 gain.

Ordered merge preparation

This increment was replayed onto main a12175e7f1862, after #1015. New head f442c7e81dcf has exactly the same file content as reviewed head e2023e3d12a5 (full-tree diff equality). Fresh committed control is complete / passed; exact-head CI for the replay passed all 14 applicable checks; release-tag-only check skipped. The preceding main commit passed all 13 CI jobs before this merge. Baseline implementation remains deferred.

Post-merge main verification

Squash-merged as c5ba436e09bce9fdc7540c50029b945fb2b322ba. The main tree exactly matches the reviewed PR head. Post-merge targeted tests passed: 148 tests. Fresh committed verification on that main commit returned complete / passed. Main CI run completed successfully with all 13 jobs passed. Baseline, corpus, ledger, Q2 and released-build evaluation remain deferred.

@pengfei-threemoonslab
pengfei-threemoonslab marked this pull request as ready for review October 10, 2026 18:56
@pengfei-threemoonslab
pengfei-threemoonslab changed the base branch from main to codex/application-action-915 October 10, 2026 20:00
@pengfei-threemoonslab
pengfei-threemoonslab force-pushed the codex/application-action-915 branch from 1d41959 to 2ebca54 Compare October 10, 2026 22:07
@pengfei-threemoonslab
pengfei-threemoonslab changed the base branch from codex/application-action-915 to main October 10, 2026 22:22
@pengfei-threemoonslab
pengfei-threemoonslab merged commit c5ba436 into main Oct 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant