Repository navigation
feat(application): identify SDK agents with computed names - #1016
Merged
Merged
Conversation
pengfei-threemoonslab
marked this pull request as ready for review
October 10, 2026 18:56
1 of 2 tasks
pengfei-threemoonslab
force-pushed
the
codex/912-source-identity
branch
from
October 10, 2026 19:59
e56b7dd to
e2023e3
Compare
pengfei-threemoonslab
changed the base branch from
main
to
codex/application-action-915
October 10, 2026 20:00
pengfei-threemoonslab
force-pushed
the
codex/application-action-915
branch
from
October 10, 2026 22:07
1d41959 to
2ebca54
Compare
pengfei-threemoonslab
changed the base branch from
codex/application-action-915
to
main
October 10, 2026 22:22
pengfei-threemoonslab
force-pushed
the
codex/912-source-identity
branch
from
October 10, 2026 22:23
e2023e3 to
f442c7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computed SDK names no longer hide a uniquely identifiable construction. A returned builder or class-held attribute receives a stable source label when the existing variable/literal rules cannot identify it. Line changes and moves between a class's methods do not change that label; competing constructions are refused rather than joined.
Refs #912. Targets
mainafter #1015 was squash-merged, following the owner-approved implementation order. This is the source-identity increment that can land before #874's instance/template tool flow. Concrete-subclass expansion and full #912 acceptance remain open. The owner deferred corpus, ledger, Q2 and released-build baseline work to separate implementation.Behavior
not_established.Authorship
Validation
New source-identity tests: 17 passed, including computed names, builder returns, class moves, collisions, bidirectional unread factories, handoff target renames and edited file moves.
Identity/unobserved regression selection: 121 passed.
Application comparison/review/shard compatibility: 85 passed.
Related SDK builder and schema selection: 3,140 passed, 120 existing expected-failure cases.
Final affected source-identity/review selection: 42 passed.
Ruff and diff whitespace checks passed. The new shard weight has measured JUnit provenance; existing full-suite weights are retained.
Committed-source verifier/control:
complete, release decisionpassed.Original exact-head GitHub CI: all applicable required checks passed; release-tag-only check skipped.
Sequential restack at
e2023e3d12a5: original source-identity patch retained alongside fix(application): retain unread SDK tool-list candidates #1010; 30 candidate/source-identity tests passed. Committed control iscomplete/passed; exact-head GitHub CI passed all 14 applicable checks, including six suite shards and aggregate coverage; the release-tag-only check was skipped.Final six-increment combination at
a4ea56e5987bf: 1,546 tests passed, 1 skipped; independent combination review passed 383 tests with no actionable P1/P2. Source remained unchanged during both selections. No corpus or baseline was scored.Independent review and fixes
These reviews did not score a corpus or establish a Q2 gain.
Ordered merge preparation
This increment was replayed onto main
a12175e7f1862, after #1015. New headf442c7e81dcfhas exactly the same file content as reviewed heade2023e3d12a5(full-tree diff equality). Fresh committed control iscomplete/passed; exact-head CI for the replay passed all 14 applicable checks; release-tag-only check skipped. The preceding main commit passed all 13 CI jobs before this merge. Baseline implementation remains deferred.Post-merge main verification
Squash-merged as
c5ba436e09bce9fdc7540c50029b945fb2b322ba. The main tree exactly matches the reviewed PR head. Post-merge targeted tests passed: 148 tests. Fresh committed verification on that main commit returnedcomplete/passed. Main CI run completed successfully with all 13 jobs passed. Baseline, corpus, ledger, Q2 and released-build evaluation remain deferred.