Repository navigation
feat(application): follow conditional builders and owned agent fields - #1017
Merged
Merged
Conversation
pengfei-threemoonslab
marked this pull request as ready for review
October 10, 2026 19:16
1 of 2 tasks
pengfei-threemoonslab
force-pushed
the
codex/912-source-identity
branch
from
October 10, 2026 19:59
e56b7dd to
e2023e3
Compare
pengfei-threemoonslab
force-pushed
the
codex/874-instance-tool-flow
branch
from
October 10, 2026 20:01
bef21d5 to
73c42ad
Compare
pengfei-threemoonslab
force-pushed
the
codex/912-source-identity
branch
from
October 10, 2026 22:23
e2023e3 to
f442c7e
Compare
pengfei-threemoonslab
changed the base branch from
codex/912-source-identity
to
main
October 10, 2026 22:39
pengfei-threemoonslab
force-pushed
the
codex/874-instance-tool-flow
branch
from
October 10, 2026 22:39
73c42ad to
46e404e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An application comparison can now read closed caller arguments when the builder constructs an agent inside an
if/else, and can follow a capability field of an already identified SDK/ADK agent to its unchanged constructor list. Rows retain caller/construction conditions and the actual tool or handoff identity.Refs #874. Stacked on #1016 (
codex/912-source-identity). This bounded increment leaves customself.tools, concrete-subclass/template expansion and full #874 acceptance open. The owner deferred corpus, ledger, Q2 and released-build baseline work to separate implementation.Boundaries
Authorship
Validation
48 new tests passed: SDK/ADK branches, genuine application additions, tools/handoffs/sub-agent reads, direct and factory replacements, mutations/escapes and name-alike/custom-instance limits.
Related selection before final fixes: 3,316 passed, 120 existing expected-failure cases.
Final affected builder/list/object-ownership selection: 1,283 passed, 120 existing expected-failure cases.
Source-identity/application-review/shard compatibility selection: 71 passed.
Ruff and diff whitespace checks passed. New shard weights have measured JUnit provenance; full-suite weights remain intact.
Original committed-source verifier/control at
bef21d5ac7bf:complete, release decisionpassed.Original exact-head GitHub CI at
bef21d5ac7bf: all 14 applicable checks passed; release-tag-only check skipped.Sequential restack at
73c42ad419e1: source patch retained; 48 flow tests passed with preceding increments. Test-only EOF whitespace fixed. Committed control iscomplete/passed; exact-head GitHub CI passed all 14 applicable checks, including six suite shards and aggregate coverage; the release-tag-only check was skipped.Final unchanged-source six-increment combination at
a4ea56e5987bf: 1,546 tests passed, 1 skipped; independent combination review passed 383 tests with no actionable P1/P2. No corpus or baseline was scored.Independent review and fixes
Ordered merge preparation
This increment was replayed onto main
c5ba436e09bc, after #1016. New head46e404e1b639has exactly the same file content as reviewed head73c42ad419e1(full-tree diff equality). Fresh committed control iscomplete/passed; exact-head CI for the replay passed all 14 applicable checks; release-tag-only check skipped. The preceding main commit passed all 13 CI jobs before this merge. Baseline implementation remains deferred.Post-merge main verification
Squash-merged as
337fb5cd44ebd815b85a6ec61f1c96bd72626d85. The main tree exactly matches the reviewed PR head. Post-merge targeted tests passed: 48 tests. Fresh committed verification on that main commit returnedcomplete/passed. Main CI run completed successfully with all 13 jobs passed. Baseline, corpus, ledger, Q2 and released-build evaluation remain deferred.