Rewrite Qt imports without wildcards - #3881
Merged
Merged
Conversation
nycrat
requested review from
Andrewyx,
StarrryNight,
sauravbanna and
williamckha
as code owners
August 19, 2026 02:43
nycrat
force-pushed
the
avah/remove_wildcard_imports_qt
branch
from
August 20, 2026 03:03
54ae9b2 to
9d8c8a8
Compare
Apeiros-46B
previously approved these changes
Aug 22, 2026
Apeiros-46B
left a comment
Member
There was a problem hiding this comment.
LGTM, thunderscope works and tests are passing for me too
GrayHoang
reviewed
Aug 22, 2026
GrayHoang
left a comment
Contributor
There was a problem hiding this comment.
Minor nits, thanks for cleaning this up
nycrat
force-pushed
the
avah/remove_wildcard_imports_qt
branch
from
August 24, 2026 21:45
fd34ee4 to
fecd004
Compare
GrayHoang
approved these changes
Aug 25, 2026
StarrryNight
approved these changes
Aug 25, 2026
StarrryNight
left a comment
Contributor
There was a problem hiding this comment.
Looked at a few of them and they Lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Look at #3645 for context. Basically we're trying to remove all wildcard imports in python because they don't work well with LSP, and contributes to namespace pollution (https://peps.python.org/pep-0008/#imports).
This PR re-writes all the import statements related to Qt/our Thunderscope graphics code to not use wildcard imports, and instead imports entire modules instead.
Testing Done
Ran thunderscope, and the UI and simulated gameplay looks the same. Also ran the full test suite, and all tests pass.
Resolved Issues
contributes to #3645, but not resolved yet
Length Justification and Key Files to Review
Lots of small refactoring changes, should be easy to review.
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue