Skip to content

fix(firered): match naming screen and rival intro visuals - #68

Merged
UNDERdecoded merged 2 commits into
UNDERdecoded:mainfrom
Lokesh-shiva:firered-name-entry-fidelity
Oct 19, 2026
Merged

fix(firered): match naming screen and rival intro visuals#68
UNDERdecoded merged 2 commits into
UNDERdecoded:mainfrom
Lokesh-shiva:firered-name-entry-fidelity

Conversation

@Lokesh-shiva

@Lokesh-shiva Lokesh-shiva commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the handmade FireRed naming help controls with the retail DPAD/A/B keypad art and right-aligned help-bar composition
  • restore the fixed name-entry arrow placement/wobble and cartridge cursor palette pulse
  • correct Oak's rival/platform name-menu shift and Gen 3 WindowTemplate frame geometry
  • force the fresh-new-game Type 1 frame for Oak intro menus without changing default Menu/Font callers
  • bump the ROM cache format to v361 so existing FireRed caches regenerate the new naming assets

Validation

  • cross-checked against pokefirered naming/Oak source and FireRed USA BPRE ROM data
  • verified the keypad sheet at ROM offset 0x1EA700 / GBA 0x081EA700, including the text-window palette used by the banner
  • git diff --check passes
  • captured player naming, rival naming, cursor motion, and the rival preset scene; visual result approved

Scope

FireRed naming/Oak visual fidelity only. Review screenshots in ngshots/ were intentionally not committed.

@Lokesh-shiva Lokesh-shiva mentioned this pull request Oct 12, 2026
Merged
@Lokesh-shiva @claude
Merge origin/main into firered-name-entry-fidelity
f753012 
NamingScreen banner: keep this PR's cartridge keypad icons when the constants
carry them (FireRed) and fall back to main's boxed hints for Emerald's naming
screen. Input arrow wobble stays FireRed-only; Emerald keeps main's blink.
Extractor: write to constants[constantKey] as main's shared extractor expects,
keeping the cursor-pulse base colour.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@UNDERdecoded
UNDERdecoded merged commit 6d4a7cd into UNDERdecoded:main Oct 19, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lokesh-shiva @UNDERdecoded