Repository navigation
fix(firered): match Oak intro, PC, and new-game visuals - #71
Merged
UNDERdecoded merged 4 commits intoOct 19, 2026
Merged
Conversation
NamingScreen banner: keep this PR's cartridge keypad icons when the constants carry them (FireRed) and fall back to main's boxed hints for Emerald's naming screen. Input arrow wobble stays FireRed-only; Emerald keeps main's blink. Extractor: write to constants[constantKey] as main's shared extractor expects, keeping the cursor-pulse base colour. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkpassesDependency
This branch is stacked on #68 (
firered-name-entry-fidelity, commit4457007), which is still open. Once #68 lands inmain, this PR should reduce to the new visual-bugs commit (9f6d5ac) only.