Update gdb_expansion.ts#464
Open
xiaoyun94 wants to merge 1 commit into
Open
Conversation
Resolved the issue that the input parameter value of a function cannot be displayed when the structure pointer is used as the input parameter of the function.
Author
|
Before: Now: |
GitMensch
reviewed
Jul 20, 2026
Comment on lines
+232
to
233
| if (extra && MINode.valueOf(extra, "type") == "char **") { | ||
| ref = variableCreate(getNamespace("*(" + name), { arg: true }); |
Collaborator
There was a problem hiding this comment.
the previous version checked if it is an arg - and showed it that way + got the content, now that is always done if the type is a char **...
Do we need to split that (haven't checked what arg:true does)?
Also: is it possible to add a testcase for that to ensure a follow-up commit does not break it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved the issue that the input parameter value of a function cannot be displayed when the structure pointer is used as the input parameter of the function.